Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: pkg/front_end/lib/src/fasta/fasta.dart

Issue 2887163003: Move the 'verify' flag to buildProgram(). (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/fasta.dart
diff --git a/pkg/front_end/lib/src/fasta/fasta.dart b/pkg/front_end/lib/src/fasta/fasta.dart
index bf5d6ee57d43ad1040b1405983f1e4e24183a02e..8a700879f34a0ccc735d9bc1d74991ad3fef3b0b 100644
--- a/pkg/front_end/lib/src/fasta/fasta.dart
+++ b/pkg/front_end/lib/src/fasta/fasta.dart
@@ -158,9 +158,9 @@ class CompileTask {
KernelTarget kernelTarget = await buildOutline();
if (exitCode != 0) return null;
Uri uri = c.options.output;
- var program = await kernelTarget.buildProgram();
+ var program = await kernelTarget.buildProgram(verify: c.options.verify);
if (c.options.dumpIr) printProgramText(program);
- await kernelTarget.writeProgram(uri, verify: c.options.verify);
+ await kernelTarget.writeProgram(uri);
return uri;
}
}
@@ -200,9 +200,7 @@ Future<CompilationResult> parseScriptInFileSystem(
await kernelTarget.buildOutlines();
program = await kernelTarget.buildProgram();
if (kernelTarget.errors.isNotEmpty) {
- return new CompilationResult.errors(kernelTarget.errors
- .map((err) => err.toString())
- .toList(growable: false));
+ return new CompilationResult.errors(kernelTarget.errors);
}
} on InputError catch (e) {
return new CompilationResult.error(e.format());

Powered by Google App Engine
This is Rietveld 408576698