Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2887153003: Timeline: fix the label of reload action on the landing page (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 649 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 660
661 var learnMoreNode = UI.createExternalLink( 661 var learnMoreNode = UI.createExternalLink(
662 'https://developers.google.com/web/tools/chrome-devtools/evaluate-perfor mance/', 662 'https://developers.google.com/web/tools/chrome-devtools/evaluate-perfor mance/',
663 Common.UIString('Learn\xa0more')); 663 Common.UIString('Learn\xa0more'));
664 var learnMoreMigrationNode = UI.createExternalLink( 664 var learnMoreMigrationNode = UI.createExternalLink(
665 'https://developers.google.com/web/updates/2016/12/devtools-javascript-c pu-profile-migration', 665 'https://developers.google.com/web/updates/2016/12/devtools-javascript-c pu-profile-migration',
666 Common.UIString('Learn\xa0more')); 666 Common.UIString('Learn\xa0more'));
667 667
668 var recordKey = 668 var recordKey =
669 encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsForAction('ti meline.toggle-recording')[0].name); 669 encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsForAction('ti meline.toggle-recording')[0].name);
670 var reloadKey = encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsF orAction('main.reload')[0].name); 670 var reloadKey =
671 encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsForAction('ti meline.record-reload')[0].name);
671 var navigateNode = encloseWithTag('b', Common.UIString('WASD')); 672 var navigateNode = encloseWithTag('b', Common.UIString('WASD'));
672 673
673 this._landingPage = new UI.VBox(); 674 this._landingPage = new UI.VBox();
674 this._landingPage.contentElement.classList.add('timeline-landing-page', 'fil l'); 675 this._landingPage.contentElement.classList.add('timeline-landing-page', 'fil l');
675 var centered = this._landingPage.contentElement.createChild('div'); 676 var centered = this._landingPage.contentElement.createChild('div');
676 677
677 var recordButton = UI.createInlineButton(UI.Toolbar.createActionButton(this. _toggleRecordAction)); 678 var recordButton = UI.createInlineButton(UI.Toolbar.createActionButton(this. _toggleRecordAction));
678 var reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId( 'timeline.record-reload')); 679 var reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId( 'timeline.record-reload'));
679 680
680 centered.createChild('p').appendChild(UI.formatLocalized( 681 centered.createChild('p').appendChild(UI.formatLocalized(
681 'Click the record button %s or hit %s to capture a new recording.\n' + 682 'Click the record button %s or hit %s to start a new recording.\n' +
682 'Click the reload button %s or hit %s to record and evaluate the page lo ad.', 683 'Click the reload button %s or hit %s to record the page load.',
683 [recordButton, recordKey, reloadButton, reloadKey])); 684 [recordButton, recordKey, reloadButton, reloadKey]));
684 685
685 centered.createChild('p').appendChild(UI.formatLocalized( 686 centered.createChild('p').appendChild(UI.formatLocalized(
686 'After recording, select an area of interest in the overview by dragging .\n' + 687 'After recording, select an area of interest in the overview by dragging .\n' +
687 'Then, zoom and pan the timeline with the mousewheel or %s keys.\n%s', 688 'Then, zoom and pan the timeline with the mousewheel or %s keys.\n%s',
688 [navigateNode, learnMoreNode])); 689 [navigateNode, learnMoreNode]));
689 690
690 var cpuProfilerHintSetting = Common.settings.createSetting('timelineShowProf ilerHint', true); 691 var cpuProfilerHintSetting = Common.settings.createSetting('timelineShowProf ilerHint', true);
691 if (cpuProfilerHintSetting.get()) { 692 if (cpuProfilerHintSetting.get()) {
692 var warning = centered.createChild('p', 'timeline-landing-warning'); 693 var warning = centered.createChild('p', 'timeline-landing-warning');
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
1302 return true; 1303 return true;
1303 case 'timeline.jump-to-next-frame': 1304 case 'timeline.jump-to-next-frame':
1304 panel._jumpToFrame(1); 1305 panel._jumpToFrame(1);
1305 return true; 1306 return true;
1306 } 1307 }
1307 return false; 1308 return false;
1308 } 1309 }
1309 }; 1310 };
1310 1311
1311 Timeline.TimelinePanel._traceProviderSettingSymbol = Symbol('traceProviderSettin g'); 1312 Timeline.TimelinePanel._traceProviderSettingSymbol = Symbol('traceProviderSettin g');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698