Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2887133005: Assert that form submission state is not one of the autofill states when (Closed)

Created:
3 years, 7 months ago by csashi
Modified:
3 years, 7 months ago
Reviewers:
Mathieu, sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert that form submission state is not one of the autofill states when we do not have the parse time. BUG=722947 Review-Url: https://codereview.chromium.org/2887133005 Cr-Commit-Position: refs/heads/master@{#472949} Committed: https://chromium.googlesource.com/chromium/src/+/c9b9e4bedcd8c49fdfaf556f538859918c0be26b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_metrics.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
csashi
Hi, Please take a look. Thanks! -sashi.
3 years, 7 months ago (2017-05-18 17:23:50 UTC) #2
sebsg
LGTM, thank you!
3 years, 7 months ago (2017-05-18 17:54:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887133005/1
3 years, 7 months ago (2017-05-18 19:23:05 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 22:18:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9b9e4bedcd8c49fdfaf556f5388...

Powered by Google App Engine
This is Rietveld 408576698