Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2887103003: Revert of SimpleIndex: Temporarily make thread checking active to chase a crash (Closed)

Created:
3 years, 7 months ago by Maks Orlovich
Modified:
3 years, 7 months ago
Reviewers:
pasko
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SimpleIndex: Temporarily make thread checking active to chase a crash (patchset #2 id:20001 of https://codereview.chromium.org/2822573004/ ) Reason for revert: Extra checks meant for short-term experiment only. Didn't catch anything, and we're getting close to new branch. BUG=710994 Review-Url: https://codereview.chromium.org/2887103003 Cr-Commit-Position: refs/heads/master@{#472497} Committed: https://chromium.googlesource.com/chromium/src/+/0a8b311a57778b4ae93c004e8758421c14cb9d0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M net/disk_cache/simple/simple_index.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/disk_cache/simple/simple_index.cc View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Maks Orlovich
Created Revert of SimpleIndex: Temporarily make thread checking active to chase a crash
3 years, 7 months ago (2017-05-17 14:30:01 UTC) #1
pasko
lgtm
3 years, 7 months ago (2017-05-17 17:35:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887103003/1
3 years, 7 months ago (2017-05-17 17:38:16 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 18:12:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a8b311a57778b4ae93c004e8758...

Powered by Google App Engine
This is Rietveld 408576698