MIPS[64]: Reland of `Fix unaligned arguments storage in Wasm-to-interpreter entry`

src/compiler/wasm-compiler.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_WASM_COMPILER_H_
 #define V8_COMPILER_WASM_COMPILER_H_
 
 #include <memory>
 
 // Clients of this interface shouldn't depend on lots of compiler internals.
@@ skipping 10 matching lines @@
 namespace v8 {
 namespace internal {
 
 namespace compiler {
 // Forward declarations for some compiler data structures.
 class Node;
 class JSGraph;
 class Graph;
 class Operator;
 class SourcePositionTable;
+class MachineOperatorBuilder;
 }  // namespace compiler
 
 namespace wasm {
 // Forward declarations for some WASM data structures.
 struct ModuleBytesEnv;
 struct ModuleEnv;
 struct WasmFunction;
 struct WasmModule;
 class ErrorThrower;
 struct DecodeStruct;
@@ skipping 248 matching lines @@
 
   // Internal helper methods.
   JSGraph* jsgraph() { return jsgraph_; }
   Graph* graph();
 
   Node* String(const char* string);
   Node* MemSize();
   Node* MemBuffer(uint32_t offset);
   void BoundsCheckMem(MachineType memtype, Node* index, uint32_t offset,
                       wasm::WasmCodePosition position);
-
+  const Operator* GetSafeStoreOperator(MachineOperatorBuilder* machine,

[Clemens Hammacher, 2017/05/26 11:02:13]

Since this is a method on the WasmGraphBuilder, you don't need to pass the
MachineOperatorBuilder explicitly. Just use "jsgraph()->machine()" inside the
method.
Alternatively, leave it as is but define it in an anonymous namespace in
wasm-compiler.cc.

+                                       int offset, wasm::ValueType type);
   Node* BuildChangeEndianness(Node* node, MachineType type,
                               wasm::ValueType wasmtype = wasm::kWasmStmt);
 
   Node* MaskShiftCount32(Node* node);
   Node* MaskShiftCount64(Node* node);
 
   Node* BuildCCall(MachineSignature* sig, Node** args);
   Node* BuildWasmCall(wasm::FunctionSig* sig, Node** args, Node*** rets,
                       wasm::WasmCodePosition position);
 
@@ skipping 95 matching lines @@
   }
 
   int AddParameterNodes(Node** args, int pos, int param_count,
                         wasm::FunctionSig* sig);
 };
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_WASM_COMPILER_H_