Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 288703002: Add get_syzygy_binaries.py script. (Closed)

Created:
6 years, 7 months ago by chrisha
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add get_syzygy_binaries.py script. This adds a script for retrieving and installing Syzygy binaries. Currently binaries are checked in to an SVN repository and installed via a DEPS dependency. The Syzygy team is moving to git, and archiving their binaries on Google Common Data Storage. A later CL will move to using this script, installing the binaries via a DEPS hook. BUG= R=siggi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270401 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270531

Patch Set 1 #

Patch Set 2 : Now with chmod=+x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -0 lines) Patch
A build/get_syzygy_binaries.py View 1 1 chunk +374 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
chrisha
OK, you win :) PTAL
6 years, 7 months ago (2014-05-14 13:35:23 UTC) #1
chrisha
This is a clone of a script in the Syzygy repo, reviewed here: https://codereview.appspot.com/94270045
6 years, 7 months ago (2014-05-14 13:59:18 UTC) #2
Sigurður Ásgeirsson
lgtm
6 years, 7 months ago (2014-05-14 14:06:07 UTC) #3
chrisha
The CQ bit was checked by chrisha@chromium.org
6 years, 7 months ago (2014-05-14 14:21:16 UTC) #4
chrisha
The CQ bit was unchecked by chrisha@chromium.org
6 years, 7 months ago (2014-05-14 14:21:21 UTC) #5
chrisha
Thanks, committing.
6 years, 7 months ago (2014-05-14 14:21:28 UTC) #6
chrisha
Committed patchset #1 manually as r270401 (presubmit successful).
6 years, 7 months ago (2014-05-14 14:27:01 UTC) #7
jiayl
A revert of this CL has been created in https://codereview.chromium.org/279053004/ by jiayl@chromium.org. The reason for ...
6 years, 7 months ago (2014-05-14 17:42:39 UTC) #8
chrisha
Sorry for the hassle here. This was checked in from Windows, where the presubmit doesn't ...
6 years, 7 months ago (2014-05-14 18:33:44 UTC) #9
chrisha
Reopened this CL, with chmod=+x applied. PTAL?
6 years, 7 months ago (2014-05-14 21:08:18 UTC) #10
Sigurður Ásgeirsson
lgtm - ship it!`
6 years, 7 months ago (2014-05-14 21:09:34 UTC) #11
chrisha
The CQ bit was checked by chrisha@chromium.org
6 years, 7 months ago (2014-05-14 21:11:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/288703002/40001
6 years, 7 months ago (2014-05-14 21:12:55 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 23:11:30 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 00:13:53 UTC) #15
Message was sent while issue was closed.
Change committed as 270531

Powered by Google App Engine
This is Rietveld 408576698