Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py

Issue 2887023002: Pass False for fromSurface argument to Page.captureScreenshot. (Closed)
Patch Set: Add TODO about supporting headless mode. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py
index 0c37347fc88986c731aad32efb9812dc17fb2e3e..3ca06345d8a363309eced59ad65d880e92303474 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py
@@ -138,7 +138,12 @@ class InspectorPage(object):
def CaptureScreenshot(self, timeout=60):
request = {
- 'method': 'Page.captureScreenshot'
+ 'method': 'Page.captureScreenshot',
+ # TODO(rmistry): when Chrome is running in headless mode, this
+ # will need to pass True. Telemetry needs to understand
+ # whether the browser is in headless mode, and pass that
+ # knowledge down to this method.
+ 'fromSurface': False
}
# "Google API are missing..." infobar might cause a viewport resize
# which invalidates screenshot request. See crbug.com/459820.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698