third_party/WebKit/Source/core/frame/FrameSerializer.cpp - Issue 2886943003: [Offline Pages] Adding missing image/CSS detection in FrameSerializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

Issue 2886943003: [Offline Pages] Adding missing image/CSS detection in FrameSerializer. (Closed)

Patch Set: comments from dcheng@. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

index a2258654313ad94f65350fda26b7e48f38c62b14..972e0d814c6ed4e43e261eeb8d0634d69f4e2e2b 100644

--- a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

@@ -301,6 +301,7 @@ void FrameSerializer::SerializeFrame(const LocalFrame& frame) {

for (Node* node : serialized_nodes) {

DCHECK(node);

+ delegate_.VisitNode(node);

fgorski 2017/05/30 17:37:50 where is the corresponding call to visiting done?

romax 2017/06/01 20:00:06 Done.

if (!node->IsElementNode())

continue;