third_party/WebKit/Source/core/frame/FrameSerializer.h - Issue 2886943003: [Offline Pages] Adding missing image/CSS detection in FrameSerializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameSerializer.h

Issue 2886943003: [Offline Pages] Adding missing image/CSS detection in FrameSerializer. (Closed)

Patch Set: Remove interfaces and add code into iteration. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameSerializer.h

diff --git a/third_party/WebKit/Source/core/frame/FrameSerializer.h b/third_party/WebKit/Source/core/frame/FrameSerializer.h

index b53d02d984a0f7defee3763e8f5217ef5ff9e5fd..76da79c56eafd39c43f58c2e1669d850968c2bc2 100644

--- a/third_party/WebKit/Source/core/frame/FrameSerializer.h

+++ b/third_party/WebKit/Source/core/frame/FrameSerializer.h

@@ -107,6 +107,8 @@ class CORE_EXPORT FrameSerializer final {

virtual Vector<Attribute> GetCustomAttributes(const Element&) {

return Vector<Attribute>();

}

+ virtual bool ShouldCollectProblemMetric() { return false; }

};

// Constructs a serializer that will write output to the given deque of