chrome/browser/ui/toolbar/app_menu_model.cc - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/app_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc

index f9468e714b1ef1382ee070b083512881b9a19cc0..8a63b61dacf24be3033829a3845c5a946159b34e 100644

--- a/chrome/browser/ui/toolbar/app_menu_model.cc

+++ b/chrome/browser/ui/toolbar/app_menu_model.cc

@@ -583,7 +583,7 @@ void AppMenuModel::LogMenuMetrics(int command_id) {

}

-void AppMenuModel::LogMenuAction(int action_id) {

+void AppMenuModel::LogMenuAction(AppMenuAction action_id) {

UMA_HISTOGRAM_ENUMERATION("WrenchMenu.MenuAction", action_id,

LIMIT_MENU_ACTION);

}