net/quic/chromium/quic_connection_logger.cc - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_connection_logger.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: fix new errors Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_connection_logger.cc

diff --git a/net/quic/chromium/quic_connection_logger.cc b/net/quic/chromium/quic_connection_logger.cc

index e50792ceaed29a6d823c2b81b785c6e300d0034f..d047462217549f7cca177e12bebac7f6cc095a4b 100644

--- a/net/quic/chromium/quic_connection_logger.cc

+++ b/net/quic/chromium/quic_connection_logger.cc

@@ -268,7 +268,8 @@ void UpdatePublicResetAddressMismatchHistogram(

return;

}

UMA_HISTOGRAM_ENUMERATION("Net.QuicSession.PublicResetAddressMismatch2",

- sample, QUIC_ADDRESS_MISMATCH_MAX);

+ static_cast<QuicAddressMismatch>(sample),

+ QUIC_ADDRESS_MISMATCH_MAX);

}

// If |address| is an IPv4-mapped IPv6 address, returns ADDRESS_FAMILY_IPV4