ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: fix new errors Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/histogram_macros_internal.h ('K') | « content/renderer/input/render_widget_input_handler.cc ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

diff --git a/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm b/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

index 56528cada54e2c24d39f6fbc482aae2b5d2b4953..66450e0b92c5a0ba67614d068d8b1fe1bf5e8c21 100644

--- a/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

+++ b/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

@@ -165,8 +165,10 @@ enum PhysicalWebInitialStateIosChrome {

}

DCHECK(state < PHYSICAL_WEB_INITIAL_STATE_COUNT);

- UMA_HISTOGRAM_ENUMERATION("PhysicalWeb.InitialState.IosChrome", state,

- PHYSICAL_WEB_INITIAL_STATE_COUNT);

+ UMA_HISTOGRAM_ENUMERATION(

+ "PhysicalWeb.InitialState.IosChrome",

+ static_cast<PhysicalWebInitialStateIosChrome>(state),

+ PHYSICAL_WEB_INITIAL_STATE_COUNT);

}

@end