Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: components/signin/core/browser/signin_metrics.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: simplify type checking Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/signin/core/browser/signin_metrics.h" 5 #include "components/signin/core/browser/signin_metrics.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 "Signin.Reconciler.ExternalCcResultTime.NotCompleted", 179 "Signin.Reconciler.ExternalCcResultTime.NotCompleted",
180 time_to_check_connections); 180 time_to_check_connections);
181 } 181 }
182 } 182 }
183 183
184 void LogAuthError(GoogleServiceAuthError::State auth_error) { 184 void LogAuthError(GoogleServiceAuthError::State auth_error) {
185 UMA_HISTOGRAM_ENUMERATION("Signin.AuthError", auth_error, 185 UMA_HISTOGRAM_ENUMERATION("Signin.AuthError", auth_error,
186 GoogleServiceAuthError::State::NUM_STATES); 186 GoogleServiceAuthError::State::NUM_STATES);
187 } 187 }
188 188
189 void LogSigninConfirmHistogramValue(int action) { 189 void LogSigninConfirmHistogramValue(ConfirmationUsage action) {
190 UMA_HISTOGRAM_ENUMERATION("Signin.OneClickConfirmation", action, 190 UMA_HISTOGRAM_ENUMERATION("Signin.OneClickConfirmation", action,
191 signin_metrics::HISTOGRAM_CONFIRM_MAX); 191 signin_metrics::HISTOGRAM_CONFIRM_MAX);
192 } 192 }
193 193
194 void LogXDevicePromoEligible(CrossDevicePromoEligibility metric) { 194 void LogXDevicePromoEligible(CrossDevicePromoEligibility metric) {
195 UMA_HISTOGRAM_ENUMERATION( 195 UMA_HISTOGRAM_ENUMERATION(
196 "Signin.XDevicePromo.Eligibility", metric, 196 "Signin.XDevicePromo.Eligibility", metric,
197 NUM_CROSS_DEVICE_PROMO_ELIGIBILITY_METRICS); 197 NUM_CROSS_DEVICE_PROMO_ELIGIBILITY_METRICS);
198 } 198 }
199 199
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 "Signin.CookieJar.ChromeAccountRelation", type, 246 "Signin.CookieJar.ChromeAccountRelation", type,
247 static_cast<int>(relation), 247 static_cast<int>(relation),
248 static_cast<int>(AccountRelation::HISTOGRAM_COUNT)); 248 static_cast<int>(AccountRelation::HISTOGRAM_COUNT));
249 } 249 }
250 250
251 void LogIsShared(const bool is_shared, const ReportingType type) { 251 void LogIsShared(const bool is_shared, const ReportingType type) {
252 INVESTIGATOR_HISTOGRAM_BOOLEAN("Signin.IsShared", type, is_shared); 252 INVESTIGATOR_HISTOGRAM_BOOLEAN("Signin.IsShared", type, is_shared);
253 } 253 }
254 254
255 } // namespace signin_metrics 255 } // namespace signin_metrics
OLDNEW
« no previous file with comments | « components/signin/core/browser/signin_metrics.h ('k') | components/sync/driver/async_directory_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698