Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: nocompile test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler_impl.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 #include "content/public/browser/web_ui.h" 66 #include "content/public/browser/web_ui.h"
67 #include "google_apis/gaia/gaia_auth_fetcher.h" 67 #include "google_apis/gaia/gaia_auth_fetcher.h"
68 #include "google_apis/gaia/gaia_auth_util.h" 68 #include "google_apis/gaia/gaia_auth_util.h"
69 #include "google_apis/gaia/gaia_constants.h" 69 #include "google_apis/gaia/gaia_constants.h"
70 #include "google_apis/gaia/gaia_urls.h" 70 #include "google_apis/gaia/gaia_urls.h"
71 #include "net/base/url_util.h" 71 #include "net/base/url_util.h"
72 #include "ui/base/l10n/l10n_util.h" 72 #include "ui/base/l10n/l10n_util.h"
73 73
74 namespace { 74 namespace {
75 75
76 void LogHistogramValue(int action) { 76 void LogHistogramValue(signin_metrics::APAction action) {
77 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action, 77 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action,
78 signin_metrics::HISTOGRAM_MAX); 78 signin_metrics::HISTOGRAM_MAX);
79 } 79 }
80 80
81 // Returns true if |profile| is a system profile or created from one. 81 // Returns true if |profile| is a system profile or created from one.
82 bool IsSystemProfile(Profile* profile) { 82 bool IsSystemProfile(Profile* profile) {
83 return profile->GetOriginalProfile()->IsSystemProfile(); 83 return profile->GetOriginalProfile()->IsSystemProfile();
84 } 84 }
85 85
86 void RedirectToNtpOrAppsPage(content::WebContents* contents, 86 void RedirectToNtpOrAppsPage(content::WebContents* contents,
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 875
876 if (show_account_management) { 876 if (show_account_management) {
877 browser->window()->ShowAvatarBubbleFromAvatarButton( 877 browser->window()->ShowAvatarBubbleFromAvatarButton(
878 BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT, 878 BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
879 signin::ManageAccountsParams(), 879 signin::ManageAccountsParams(),
880 signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN, 880 signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN,
881 false); 881 false);
882 } 882 }
883 } 883 }
884 } 884 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698