extensions/browser/extension_prefs.cc - Issue 2886923002: [extension SW]: Support event listener registration and event dispatching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_prefs.cc

Issue 2886923002: [extension SW]: Support event listener registration and event dispatching. (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_prefs.cc

diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc

index cc8847d3c648845b824e5d0dc2a300e8610aa375..41637e1f5440db214b8df2da35b397569c6af15b 100644

--- a/extensions/browser/extension_prefs.cc

+++ b/extensions/browser/extension_prefs.cc

@@ -1926,7 +1926,8 @@ void ExtensionPrefs::FinishExtensionInfoPrefs(

extension_dict->Remove(kDelayedInstallInfo, NULL);

// Clear state that may be registered from a previous install.

- extension_dict->Remove(EventRouter::kRegisteredEvents, NULL);

+ extension_dict->Remove(EventRouter::kRegisteredLazyEvents, nullptr);

+ extension_dict->Remove(EventRouter::kRegisteredServiceWorkerEvents, nullptr);

// FYI, all code below here races on sudden shutdown because |extension_dict|,

// |app_sorting|, |extension_pref_value_map_|, and (potentially) observers