third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2886893008: [DMC #8] Rename DocumentMarkerController::RenderedRectsForMarkers()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2886893008: [DMC #8] Rename DocumentMarkerController::RenderedRectsForMarkers() (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index 16a4f234c38afd00afb891c6fdad45264339ad0a..3992a6d2b50b1acf5d7e0f3f7c1827ba94ef72cf 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -393,15 +393,9 @@ DocumentMarkerVector DocumentMarkerController::Markers() {

return result;

}

-Vector<IntRect> DocumentMarkerController::RenderedRectsForMarkers(

- DocumentMarker::MarkerType marker_type) {

- // Only TextMatch markers can have rendered rects

- // TODO(rlanday): remove marker_type parameter

- DCHECK_EQ(marker_type, DocumentMarker::kTextMatch);

+Vector<IntRect> DocumentMarkerController::RenderedRectsForTextMatchMarkers() {

Vector<IntRect> result;

- if (!PossiblyHasMarkers(marker_type))

+ if (!PossiblyHasMarkers(DocumentMarker::kTextMatch))

return result;

DCHECK(!(markers_.IsEmpty()));