pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart - Issue 2886873005: Minor type inference fixes to do with null and bottom types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart

Issue 2886873005: Minor type inference fixes to do with null and bottom types. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/testcases/inference/inferred_type_block_closure_no_args_no_return.dart.strong.expect ('k') | pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart.strong.expect » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart

diff --git a/pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart b/pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart

index 194c9cf2f360d26e2e2cbc1027a6a698b795e6c2..d8699ea4c4993df624ec8457a2d8ad3ed953dd59 100644

--- a/pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart

+++ b/pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart

@@ -23,5 +23,6 @@ main() {

(/*info:DYNAMIC_INVOKE*/ h.foo());

foo(/*@returnType=int*/ (/*@type=Object*/ x) => null);

- foo(/*@returnType=<bottom>*/ (/*@type=Object*/ x) => throw "not implemented");

+ foo(/*@returnType=<BottomType>*/ (/*@type=Object*/ x) =>

+ throw "not implemented");

}