Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: services/ui/ws/window_tree.cc

Issue 2886873002: Only send the FrameSinkId to client when it is necessary (Closed)
Patch Set: Address review issues. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ws/window_manager_client_unittest.cc ('k') | services/ui/ws/window_tree_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/window_tree.cc
diff --git a/services/ui/ws/window_tree.cc b/services/ui/ws/window_tree.cc
index d88c615f65df061f250faa63270b8f8173504f35..421b1972ee5788f2ba37a7eb021086b3dbcb1a52 100644
--- a/services/ui/ws/window_tree.cc
+++ b/services/ui/ws/window_tree.cc
@@ -146,7 +146,7 @@ void WindowTree::Init(std::unique_ptr<WindowTreeBinding> binding,
const bool drawn = root->parent() && root->parent()->IsDrawn();
client()->OnEmbed(id_, WindowToWindowData(to_send.front()), std::move(tree),
display_id, focused_window_id.id, drawn,
- root->frame_sink_id(), root->current_local_surface_id());
+ root->current_local_surface_id());
}
void WindowTree::ConfigureWindowManager(
@@ -237,8 +237,7 @@ void WindowTree::AddRootForWindowManager(const ServerWindow* root) {
window_manager_internal_->WmNewDisplayAdded(
ws_display->GetDisplay(), WindowToWindowData(root),
- root->parent()->IsDrawn(), root->frame_sink_id(),
- root->current_local_surface_id());
+ root->parent()->IsDrawn(), root->current_local_surface_id());
}
void WindowTree::OnWindowDestroyingTreeImpl(WindowTree* tree) {
@@ -662,7 +661,7 @@ void WindowTree::OnWindowManagerCreatedTopLevelWindow(
int64_t display_id = display ? display->GetId() : display::kInvalidDisplayId;
const bool drawn = window->parent() && window->parent()->IsDrawn();
client()->OnTopLevelCreated(client_change_id, WindowToWindowData(window),
- display_id, drawn, window->frame_sink_id(),
+ display_id, drawn,
window->current_local_surface_id());
}
@@ -2234,11 +2233,11 @@ void WindowTree::SetDisplayRoot(const display::Display& display,
ProcessSetDisplayRoot(display, *viewport_metrics, is_primary_display,
ClientWindowId(window_id));
if (!display_root) {
- callback.Run(base::Optional<cc::FrameSinkId>());
+ callback.Run(false);
return;
}
display_root->parent()->SetVisible(true);
- callback.Run(display_root->frame_sink_id());
+ callback.Run(true);
}
void WindowTree::WmResponse(uint32_t change_id, bool response) {
« no previous file with comments | « services/ui/ws/window_manager_client_unittest.cc ('k') | services/ui/ws/window_tree_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698