Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: services/ui/public/cpp/client_compositor_frame_sink.h

Issue 2886873002: Only send the FrameSinkId to client when it is necessary (Closed)
Patch Set: Address review issues. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/client_compositor_frame_sink.h
diff --git a/services/ui/public/cpp/client_compositor_frame_sink.h b/services/ui/public/cpp/client_compositor_frame_sink.h
index af5f13a09c3af064a5a3ff992b1b2d64f5e8922d..889cfa46697fc8410f43589a31fb2f785b570f2a 100644
--- a/services/ui/public/cpp/client_compositor_frame_sink.h
+++ b/services/ui/public/cpp/client_compositor_frame_sink.h
@@ -25,11 +25,11 @@ class ClientCompositorFrameSink
public:
// static
static std::unique_ptr<ClientCompositorFrameSink> Create(
- const cc::FrameSinkId& frame_sink_id,
scoped_refptr<cc::ContextProvider> context_provider,
gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
std::unique_ptr<ClientCompositorFrameSinkBinding>*
- compositor_frame_sink_binding);
+ compositor_frame_sink_binding,
+ bool enable_surface_synchronization);
~ClientCompositorFrameSink() override;
@@ -41,11 +41,11 @@ class ClientCompositorFrameSink
private:
ClientCompositorFrameSink(
- const cc::FrameSinkId& frame_sink_id,
scoped_refptr<cc::ContextProvider> context_provider,
gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
cc::mojom::MojoCompositorFrameSinkPtrInfo compositor_frame_sink_info,
- cc::mojom::MojoCompositorFrameSinkClientRequest client_request);
+ cc::mojom::MojoCompositorFrameSinkClientRequest client_request,
+ bool enable_surface_synchronization);
// cc::mojom::MojoCompositorFrameSinkClient implementation:
void DidReceiveCompositorFrameAck(
@@ -67,8 +67,7 @@ class ClientCompositorFrameSink
std::unique_ptr<mojo::Binding<cc::mojom::MojoCompositorFrameSinkClient>>
client_binding_;
std::unique_ptr<base::ThreadChecker> thread_checker_;
- const cc::FrameSinkId frame_sink_id_;
- bool enable_surface_synchronization_ = false;
+ const bool enable_surface_synchronization_;
DISALLOW_COPY_AND_ASSIGN(ClientCompositorFrameSink);
};
« no previous file with comments | « content/renderer/mus/renderer_window_tree_client.cc ('k') | services/ui/public/cpp/client_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698