Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: services/ui/public/interfaces/window_manager.mojom

Issue 2886873002: Only send the FrameSinkId to client when it is necessary (Closed)
Patch Set: Fix build issues Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/interfaces/window_manager.mojom
diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom
index 8608e9f350c2312f852a501be50a956cc740b5e0..bbb22439113d68bb72d10035e77ac8c84bff60cf 100644
--- a/services/ui/public/interfaces/window_manager.mojom
+++ b/services/ui/public/interfaces/window_manager.mojom
@@ -153,13 +153,11 @@ interface WindowManager {
OnConnect(uint16 client_id);
// Called when a new display is added. |root| gives the root window specific
- // to this WindowManager for |display|. |frame_sink_id| uniquely identifies
- // the window manager in the frame sink manager. |local_surface_id| identifies
- // the ID to use to submit CompositorFrames.
+ // to this WindowManager for |display|. |local_surface_id| identifies the ID
+ // to use to submit CompositorFrames.
WmNewDisplayAdded(display.mojom.Display display,
WindowData root,
bool parent_drawn,
- cc.mojom.FrameSinkId frame_sink_id,
cc.mojom.LocalSurfaceId? local_surface_id);
// Called when a display is removed. The root of the specified display is
@@ -273,13 +271,12 @@ interface WindowManagerClient {
// Sets the root of a particular display. This is only applicable when the
// WindowTree was created with a value of false for
// |automatically_create_display_roots| (see
- // WindowManagerWindowTreeFactory::CreateWindowTree() for details). On success
- // this responds with the FrameSinkId of the root. On failure the FrameSinkId
- // is not valid.
+ // WindowManagerWindowTreeFactory::CreateWindowTree() for details).
+ // Returns true if all accelerators were added successfully.
sky 2017/05/18 03:18:08 Returns true on success.
Peng 2017/05/18 13:34:56 Done.
SetDisplayRoot(display.mojom.Display display,
WmViewportMetrics viewport_metrics,
bool is_primary_display,
- uint32 window_id) => (cc.mojom.FrameSinkId? frame_sink_id);
+ uint32 window_id) => (bool success);
// The window manager has completed a request with the specific change id.
WmResponse(uint32 change_id, bool response);

Powered by Google App Engine
This is Rietveld 408576698