Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Side by Side Diff: content/renderer/mus/renderer_window_tree_client.h

Issue 2886873002: Only send the FrameSinkId to client when it is necessary (Closed)
Patch Set: Address review issues. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/mus/renderer_window_tree_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MUS_RENDERER_WINDOW_TREE_CLIENT_H_ 5 #ifndef CONTENT_RENDERER_MUS_RENDERER_WINDOW_TREE_CLIENT_H_
6 #define CONTENT_RENDERER_MUS_RENDERER_WINDOW_TREE_CLIENT_H_ 6 #define CONTENT_RENDERER_MUS_RENDERER_WINDOW_TREE_CLIENT_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "mojo/public/cpp/bindings/binding.h" 9 #include "mojo/public/cpp/bindings/binding.h"
10 #include "services/ui/common/types.h" 10 #include "services/ui/common/types.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // these will remain unimplemented in the long-term. Some of the 64 // these will remain unimplemented in the long-term. Some of the
65 // implementations would require some amount of refactoring out of 65 // implementations would require some amount of refactoring out of
66 // RenderWidget and related classes (e.g. resize, input, ime etc.). 66 // RenderWidget and related classes (e.g. resize, input, ime etc.).
67 void OnEmbed( 67 void OnEmbed(
68 ui::ClientSpecificId client_id, 68 ui::ClientSpecificId client_id,
69 ui::mojom::WindowDataPtr root, 69 ui::mojom::WindowDataPtr root,
70 ui::mojom::WindowTreePtr tree, 70 ui::mojom::WindowTreePtr tree,
71 int64_t display_id, 71 int64_t display_id,
72 ui::Id focused_window_id, 72 ui::Id focused_window_id,
73 bool drawn, 73 bool drawn,
74 const cc::FrameSinkId& frame_sink_id,
75 const base::Optional<cc::LocalSurfaceId>& local_surface_id) override; 74 const base::Optional<cc::LocalSurfaceId>& local_surface_id) override;
76 void OnEmbeddedAppDisconnected(ui::Id window_id) override; 75 void OnEmbeddedAppDisconnected(ui::Id window_id) override;
77 void OnUnembed(ui::Id window_id) override; 76 void OnUnembed(ui::Id window_id) override;
78 void OnCaptureChanged(ui::Id new_capture_window_id, 77 void OnCaptureChanged(ui::Id new_capture_window_id,
79 ui::Id old_capture_window_id) override; 78 ui::Id old_capture_window_id) override;
80 void OnFrameSinkIdAllocated(ui::Id window_id, 79 void OnFrameSinkIdAllocated(ui::Id window_id,
81 const cc::FrameSinkId& frame_sink_id) override; 80 const cc::FrameSinkId& frame_sink_id) override;
82 void OnTopLevelCreated( 81 void OnTopLevelCreated(
83 uint32_t change_id, 82 uint32_t change_id,
84 ui::mojom::WindowDataPtr data, 83 ui::mojom::WindowDataPtr data,
85 int64_t display_id, 84 int64_t display_id,
86 bool drawn, 85 bool drawn,
87 const cc::FrameSinkId& frame_sink_id,
88 const base::Optional<cc::LocalSurfaceId>& local_surface_id) override; 86 const base::Optional<cc::LocalSurfaceId>& local_surface_id) override;
89 void OnWindowBoundsChanged( 87 void OnWindowBoundsChanged(
90 ui::Id window_id, 88 ui::Id window_id,
91 const gfx::Rect& old_bounds, 89 const gfx::Rect& old_bounds,
92 const gfx::Rect& new_bounds, 90 const gfx::Rect& new_bounds,
93 const base::Optional<cc::LocalSurfaceId>& local_frame_id) override; 91 const base::Optional<cc::LocalSurfaceId>& local_frame_id) override;
94 void OnClientAreaChanged( 92 void OnClientAreaChanged(
95 uint32_t window_id, 93 uint32_t window_id,
96 const gfx::Insets& new_client_area, 94 const gfx::Insets& new_client_area,
97 const std::vector<gfx::Rect>& new_additional_client_areas) override; 95 const std::vector<gfx::Rect>& new_additional_client_areas) override;
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 uint32_t action_taken) override; 151 uint32_t action_taken) override;
154 void OnDragDropDone() override; 152 void OnDragDropDone() override;
155 void OnChangeCompleted(uint32_t change_id, bool success) override; 153 void OnChangeCompleted(uint32_t change_id, bool success) override;
156 void RequestClose(uint32_t window_id) override; 154 void RequestClose(uint32_t window_id) override;
157 void GetWindowManager( 155 void GetWindowManager(
158 mojo::AssociatedInterfaceRequest<ui::mojom::WindowManager> internal) 156 mojo::AssociatedInterfaceRequest<ui::mojom::WindowManager> internal)
159 override; 157 override;
160 158
161 const int routing_id_; 159 const int routing_id_;
162 ui::Id root_window_id_; 160 ui::Id root_window_id_;
163 cc::FrameSinkId frame_sink_id_;
164 scoped_refptr<cc::ContextProvider> pending_context_provider_; 161 scoped_refptr<cc::ContextProvider> pending_context_provider_;
165 gpu::GpuMemoryBufferManager* pending_gpu_memory_buffer_manager_ = nullptr; 162 gpu::GpuMemoryBufferManager* pending_gpu_memory_buffer_manager_ = nullptr;
166 CompositorFrameSinkCallback pending_compositor_frame_sink_callback_; 163 CompositorFrameSinkCallback pending_compositor_frame_sink_callback_;
167 ui::mojom::WindowTreePtr tree_; 164 ui::mojom::WindowTreePtr tree_;
168 mojo::Binding<ui::mojom::WindowTreeClient> binding_; 165 mojo::Binding<ui::mojom::WindowTreeClient> binding_;
169 166
170 DISALLOW_COPY_AND_ASSIGN(RendererWindowTreeClient); 167 DISALLOW_COPY_AND_ASSIGN(RendererWindowTreeClient);
171 }; 168 };
172 169
173 } // namespace content 170 } // namespace content
174 171
175 #endif // CONTENT_RENDERER_MUS_RENDERER_WINDOW_TREE_CLIENT_H_ 172 #endif // CONTENT_RENDERER_MUS_RENDERER_WINDOW_TREE_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/mus/renderer_window_tree_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698