Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_welcome.html

Issue 2886843005: [i18n] use Polymer data binding to change locale strings (Closed)
Patch Set: review changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_welcome.html
diff --git a/chrome/browser/resources/chromeos/login/oobe_welcome.html b/chrome/browser/resources/chromeos/login/oobe_welcome.html
index 34d39e4e3173a2187cc4c8091b1101df8448995e..b3f13dedd19f36f76037b9faacca7d23019e7393 100644
--- a/chrome/browser/resources/chromeos/login/oobe_welcome.html
+++ b/chrome/browser/resources/chromeos/login/oobe_welcome.html
@@ -89,9 +89,9 @@
on-accessibility-button-clicked="onWelcomeAccessibilityButtonClicked_"
on-timezone-button-clicked="onWelcomeTimezoneButtonClicked_"
on-next-button-clicked="onWelcomeNextButtonClicked_"
- timezone-button-visible="[[isTimezoneButtonVisible_(highlightStrength)]]"
- debugging-link-visible="[[debuggingLinkVisible]]"
- >
+ timezone-button-visible=
+ "[[isTimezoneButtonVisible_(highlightStrength)]]"
+ debugging-link-visible="[[debuggingLinkVisible]]">
</oobe-welcome-dialog>
<oobe-dialog id="languageScreen" role="dialog" hidden has-buttons
i18n-values="aria-label:languageSectionTitle">
@@ -99,15 +99,16 @@
icon1x="oobe-welcome-32:language" icon2x="oobe-welcome-64:language">
</hd-iron-icon>
<div class="header">
- <h1 class="title" i18n-content="languageSectionTitle"></h1>
+ <h1 class="title">[[i18n_.languageSectionTitle]]</h1>
</div>
<div class="footer layout vertical">
<template is="dom-if" if="[[enabled]]">
<div id="languageDropdownContainer"
class="flex layout center horizontal justified
language-selection-entry">
- <div class="language-selection-title layout vertical center-justified"
- i18n-content="languageDropdownTitle">
+ <div class=
+ "language-selection-title layout vertical center-justified">
+ [[i18n_.languageDropdownTitle]]
</div>
<oobe-i18n-dropdown id="languageSelect" items="[[languages]]"
on-select-item="onLanguageSelected_"
@@ -118,8 +119,9 @@
<div id="keyboardDropdownContainer"
class="flex layout center horizontal justified
language-selection-entry">
- <div class="language-selection-title layout vertical center-justified"
- i18n-content="keyboardDropdownTitle">
+ <div class=
+ "language-selection-title layout vertical center-justified">
+ [[i18n_.keyboardDropdownTitle]]
</div>
<oobe-i18n-dropdown id="keyboardSelect" items="[[keyboards]]"
on-select-item="onKeyboardSelected_"
@@ -130,7 +132,7 @@
</div>
<div class="bottom-buttons layout horizontal end-justified">
<oobe-text-button inverse on-tap="closeLanguageSection_">
- <div i18n-content="oobeOKButtonText"></div>
+ <div>[[i18n_.oobeOKButtonText]]</div>
</oobe-text-button>
</div>
</oobe-dialog>
@@ -141,8 +143,8 @@
icon2x="oobe-welcome-64:accessibility">
</hd-iron-icon>
<div class="header">
- <h1 class="title" i18n-content="accessibilitySectionTitle"></h1>
- <div class="subtitle" i18n-content="accessibilitySectionHint"></div>
+ <h1 class="title">[[i18n_.accessibilitySectionTitle]]</h1>
+ <div class="subtitle">[[i18n_.accessibilitySectionHint]]</div>
</div>
<div class="footer layout vertical">
<oobe-a11y-option checked="[[a11yStatus.spokenFeedbackEnabled]]"
@@ -150,56 +152,50 @@
chrome-message="enableSpokenFeedback"
i18n-values="label-for-aria:spokenFeedbackOption"
class="focus-on-show">
- <span class="title" i18n-content="spokenFeedbackOption"></span>
- <span class="checked-value" i18n-content="spokenFeedbackOptionOn">
- </span>
- <span class="unchecked-value" i18n-content="spokenFeedbackOptionOff">
- </span>
+ <span class="title">[[i18n_.spokenFeedbackOption]]</span>
+ <span class="checked-value">[[i18n_.spokenFeedbackOptionOn]]</span>
+ <span class="unchecked-value">[[i18n_.spokenFeedbackOptionOff]]</span>
</oobe-a11y-option>
<oobe-a11y-option checked="[[a11yStatus.largeCursorEnabled]]"
on-change="onA11yOptionChanged_"
chrome-message="enableLargeCursor"
i18n-values="label-for-aria:largeCursorOption">
- <span class="title" i18n-content="largeCursorOption"></span>
- <span class="checked-value" i18n-content="largeCursorOptionOn">
- </span>
- <span class="unchecked-value" i18n-content="largeCursorOptionOff">
- </span>
+ <span class="title">[[i18n_.largeCursorOption]]</span>
+ <span class="checked-value">[[i18n_.largeCursorOptionOn]]</span>
+ <span class="unchecked-value">[[i18n_.largeCursorOptionOff]]</span>
</oobe-a11y-option>
<oobe-a11y-option checked="[[a11yStatus.highContrastEnabled]]"
on-change="onA11yOptionChanged_"
chrome-message="enableHighContrast"
i18n-values="label-for-aria:highContrastOption">
- <span class="title" i18n-content="highContrastOption"></span>
- <span class="checked-value" i18n-content="highContrastOptionOn">
- </span>
- <span class="unchecked-value" i18n-content="highContrastOptionOff">
- </span>
+ <span class="title">[[i18n_.highContrastOption]]</span>
+ <span class="checked-value">[[i18n_.highContrastOptionOn]]</span>
+ <span class="unchecked-value">[[i18n_.highContrastOptionOff]]</span>
</oobe-a11y-option>
<oobe-a11y-option checked="[[a11yStatus.screenMagnifierEnabled]]"
on-change="onA11yOptionChanged_"
chrome-message="enableScreenMagnifier"
i18n-values="label-for-aria:screenMagnifierOption">
- <span class="title" i18n-content="screenMagnifierOption"></span>
- <span class="checked-value" i18n-content="screenMagnifierOptionOn">
- </span>
- <span class="unchecked-value" i18n-content="screenMagnifierOptionOff">
+ <span class="title">[[i18n_.screenMagnifierOption]]</span>
+ <span class="checked-value">[[i18n_.screenMagnifierOptionOn]]</span>
+ <span class="unchecked-value">
+ [[i18n_.screenMagnifierOptionOff]]
</span>
</oobe-a11y-option>
<oobe-a11y-option checked="[[a11yStatus.virtualKeyboardEnabled]]"
on-change="onA11yOptionChanged_"
chrome-message="enableVirtualKeyboard"
i18n-values="label-for-aria:virtualKeyboardOption">
- <span class="title" i18n-content="virtualKeyboardOption"></span>
- <span class="checked-value" i18n-content="virtualKeyboardOptionOn">
- </span>
- <span class="unchecked-value" i18n-content="virtualKeyboardOptionOff">
+ <span class="title">[[i18n_.virtualKeyboardOption]]</span>
+ <span class="checked-value">[[i18n_.virtualKeyboardOptionOn]]</span>
+ <span class="unchecked-value">
+ [[i18n_.virtualKeyboardOptionOff]]
</span>
</oobe-a11y-option>
</div>
<div class="bottom-buttons layout horizontal end-justified">
<oobe-text-button inverse on-tap="closeAccessibilitySection_">
- <div i18n-content="oobeOKButtonText"></div>
+ <div>[[i18n_.oobeOKButtonText]]</div>
</oobe-text-button>
</div>
</oobe-dialog>
@@ -209,13 +205,14 @@
icon1x="oobe-welcome-32:timezone" icon2x="oobe-welcome-64:timezone">
</hd-iron-icon>
<div class="header">
- <h1 class="title" i18n-content="timezoneSectionTitle"></h1>
+ <h1 class="title">[[i18n_.timezoneSectionTitle]]</h1>
</div>
<div class="footer layout vertical">
<div class="flex layout center horizontal justified
timezone-selection-entry">
- <div class="timezone-selection-title layout vertical center-justified"
- i18n-content="timezoneDropdownTitle">
+ <div class=
+ "timezone-selection-title layout vertical center-justified">
+ [[i18n_.timezoneDropdownTitle]]
</div>
<oobe-i18n-dropdown id="timezoneSelect" items="[[timezones]]"
on-select-item="onTimezoneSelected_"
@@ -226,7 +223,7 @@
</div>
<div class="bottom-buttons layout horizontal end-justified">
<oobe-text-button inverse on-tap="closeTimezoneSection_">
- <div i18n-content="oobeOKButtonText"></div>
+ <div>[[i18n_.oobeOKButtonText]]</div>
</oobe-text-button>
</div>
</oobe-dialog>
@@ -237,8 +234,8 @@
icon1x="oobe-welcome-32:wifi" icon2x="oobe-welcome-64:wifi">
</hd-iron-icon>
<div class="header">
- <h1 class="title" i18n-content="networkSectionTitle"></h1>
- <div class="subtitle" i18n-content="networkSectionHint"></div>
+ <h1 class="title">[[i18n_.networkSectionTitle]]</h1>
+ <div class="subtitle">[[i18n_.networkSectionHint]]</div>
</div>
<div class="footer layout vertical">
<cr-network-select id="networkSelect"

Powered by Google App Engine
This is Rietveld 408576698