Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1791)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 288683002: Update chrome://serviceworker-internals when ServiceWorker is unregistered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 3e6e0538e75f68a0463aece2898603cee7a68451..cbd6ce62bdd8db98b1bbe881fb7351f5f643336a 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -157,6 +157,7 @@ void ServiceWorkerContextCore::RegisterServiceWorker(
source_process_id,
base::Bind(&ServiceWorkerContextCore::RegistrationComplete,
AsWeakPtr(),
+ pattern,
callback));
}
@@ -165,10 +166,16 @@ void ServiceWorkerContextCore::UnregisterServiceWorker(
const UnregistrationCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- job_coordinator_->Unregister(pattern, callback);
+ job_coordinator_->Unregister(
+ pattern,
+ base::Bind(&ServiceWorkerContextCore::UnregistrationComplete,
+ AsWeakPtr(),
+ pattern,
+ callback));
}
void ServiceWorkerContextCore::RegistrationComplete(
+ const GURL& pattern,
const ServiceWorkerContextCore::RegistrationCallback& callback,
ServiceWorkerStatusCode status,
ServiceWorkerRegistration* registration,
@@ -186,6 +193,21 @@ void ServiceWorkerContextCore::RegistrationComplete(
callback.Run(status,
registration->id(),
version->version_id());
+ if (observer_list_) {
+ observer_list_->Notify(&ServiceWorkerContextObserver::OnRegistrationStored,
+ pattern);
+ }
+}
+
+void ServiceWorkerContextCore::UnregistrationComplete(
+ const GURL& pattern,
+ const ServiceWorkerContextCore::UnregistrationCallback& callback,
+ ServiceWorkerStatusCode status) {
+ callback.Run(status);
+ if (observer_list_) {
+ observer_list_->Notify(&ServiceWorkerContextObserver::OnRegistrationDeleted,
+ pattern);
+ }
}
ServiceWorkerRegistration* ServiceWorkerContextCore::GetLiveRegistration(

Powered by Google App Engine
This is Rietveld 408576698