chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java - Issue 2886723002: [Zine] Add a metric to record number of visible sections on NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java

Issue 2886723002: [Zine] Add a metric to record number of visible sections on NTP. (Closed)

Patch Set: clean rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporterBridge.java » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java

index 384b3da35dad8b01b7a2c16aab4e0b8a19e1f8d2..36d00b9f1e0efc6c1749a8a15b85ea1d9917a9be 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsEventReporter.java

@@ -22,8 +22,9 @@ public interface SuggestionsEventReporter {

* Tracks per-page-load metrics for content suggestions.

* @param categories The categories of content suggestions.

* @param suggestionsPerCategory The number of content suggestions in each category.

+ * @param visibleCategoriesCount The number of (possibly empty) categories visible in the UI.

- void onPageShown(int[] categories, int[] suggestionsPerCategory);

+ void onPageShown(int[] categories, int[] suggestionsPerCategory, int visibleCategoriesCount);

/**

* Tracks impression metrics for a content suggestion.