components/ntp_snippets/content_suggestions_metrics.h - Issue 2886723002: [Zine] Add a metric to record number of visible sections on NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_metrics.h

Issue 2886723002: [Zine] Add a metric to record number of visible sections on NTP. (Closed)

Patch Set: isherman@ nit. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/content_suggestions_metrics.h

diff --git a/components/ntp_snippets/content_suggestions_metrics.h b/components/ntp_snippets/content_suggestions_metrics.h

index 3bfff0ec7a5c86af956bcfcdb6cf064414e8062d..e31b77136331b8a0fbeeb201672359419d0146ff 100644

--- a/components/ntp_snippets/content_suggestions_metrics.h

+++ b/components/ntp_snippets/content_suggestions_metrics.h

@@ -16,7 +16,8 @@ namespace ntp_snippets {

namespace metrics {

void OnPageShown(

- const std::vector<std::pair<Category, int>>& suggestions_per_category);

+ const std::vector<std::pair<Category, int>>& suggestions_per_category,

+ int visible_categories_count);

// Should only be called once per NTP for each suggestion.

void OnSuggestionShown(int global_position,