DevTools test harness: add logToStderr method on testRunner.

content/shell/renderer/test_runner/test_runner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/test_runner/test_runner.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "content/shell/common/test_runner/test_preferences.h"
@@ skipping 101 matching lines @@
 
  private:
   explicit TestRunnerBindings(
       base::WeakPtr<TestRunner> controller);
   virtual ~TestRunnerBindings();
 
   // gin::Wrappable:
   virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(
       v8::Isolate* isolate) OVERRIDE;
 
+  void LogToStderr(const std::string& output);
   void NotifyDone();
   void WaitUntilDone();
   void QueueBackNavigation(int how_far_back);
   void QueueForwardNavigation(int how_far_forward);
   void QueueReload();
   void QueueLoadingScript(const std::string& script);
   void QueueNonLoadingScript(const std::string& script);
   void QueueLoad(gin::Arguments* args);
   void QueueLoadHTMLString(gin::Arguments* args);
   void SetCustomPolicyDelegate(gin::Arguments* args);
@@ skipping 156 matching lines @@
 
 TestRunnerBindings::TestRunnerBindings(base::WeakPtr<TestRunner> runner)
     : runner_(runner) {}
 
 TestRunnerBindings::~TestRunnerBindings() {}
 
 gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
     v8::Isolate* isolate) {
   return gin::Wrappable<TestRunnerBindings>::GetObjectTemplateBuilder(isolate)
       // Methods controlling test execution.
+      .SetMethod("logToStderr", &TestRunnerBindings::LogToStderr)
       .SetMethod("notifyDone", &TestRunnerBindings::NotifyDone)
       .SetMethod("waitUntilDone", &TestRunnerBindings::WaitUntilDone)
       .SetMethod("queueBackNavigation",
                  &TestRunnerBindings::QueueBackNavigation)
       .SetMethod("queueForwardNavigation",
                  &TestRunnerBindings::QueueForwardNavigation)
       .SetMethod("queueReload", &TestRunnerBindings::QueueReload)
       .SetMethod("queueLoadingScript", &TestRunnerBindings::QueueLoadingScript)
       .SetMethod("queueNonLoadingScript",
                  &TestRunnerBindings::QueueNonLoadingScript)
@@ skipping 213 matching lines @@
       .SetMethod("applicationCacheDiskUsageForOrigin",
                  &TestRunnerBindings::NotImplemented)
       .SetMethod("abortModal", &TestRunnerBindings::NotImplemented)
 
       // Aliases.
       // Used at fast/dom/assign-to-window-status.html
       .SetMethod("dumpStatusCallbacks",
                  &TestRunnerBindings::DumpWindowStatusChanges);
 }
 
+void TestRunnerBindings::LogToStderr(const std::string& output) {
+  if (runner_)

[pfeldman, 2014/05/15 14:59:12]

Is there a reason to not LOG(ERROR) here?

+    runner_->LogToStderr(output);
+}
+
 void TestRunnerBindings::NotifyDone() {
   if (runner_)
     runner_->NotifyDone();
 }
 
 void TestRunnerBindings::WaitUntilDone() {
   if (runner_)
     runner_->WaitUntilDone();
 }
 
@@ skipping 1204 matching lines @@
 
   virtual bool Run(WebTestDelegate* delegate, WebView*) OVERRIDE {
     delegate->goToOffset(distance_);
     return true; // FIXME: Did it really start a navigation?
   }
 
  private:
   int distance_;
 };
 
+void TestRunner::LogToStderr(const std::string& output) {
+  LOG(ERROR) << output;
+}
+
 void TestRunner::NotifyDone() {
   if (disable_notify_done_)
     return;
 
   // Test didn't timeout. Kill the timeout timer.
   taskList()->revokeAll();
 
   CompleteNotifyDone();
 }
 
@@ skipping 862 matching lines @@
 }
 
 void TestRunner::DidLosePointerLockInternal() {
   bool was_locked = pointer_locked_;
   pointer_locked_ = false;
   if (was_locked)
     web_view_->didLosePointerLock();
 }
 
 }  // namespace content