third_party/WebKit/Source/core/dom/ModulatorImpl.cpp - Issue 2886593002: [ES6 modules] ModuleTreeLinker::Instantiate shouldn't proceed on invalid context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

Issue 2886593002: [ES6 modules] ModuleTreeLinker::Instantiate shouldn't proceed on invalid context (Closed)

Patch Set: hasvalidcontxt Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

diff --git a/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp b/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

index 16081ff5eb37c2bf63ca026d05ba3e5108da2972..546f5d51b280e59045035b0432f160181132cdda 100644

--- a/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

+++ b/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

@@ -111,6 +111,10 @@ ModuleScript* ModulatorImpl::GetFetchedModuleScript(const KURL& url) {

return map_->GetFetchedModuleScript(url);

}

+bool ModulatorImpl::HasValidContext() {

+ return script_state_->ContextIsValid();

ScriptModule ModulatorImpl::CompileModule(

const String& provided_source,

const String& url_str,