third_party/WebKit/Source/core/testing/DummyModulator.cpp - Issue 2886593002: [ES6 modules] ModuleTreeLinker::Instantiate shouldn't proceed on invalid context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DummyModulator.cpp

Issue 2886593002: [ES6 modules] ModuleTreeLinker::Instantiate shouldn't proceed on invalid context (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DummyModulator.cpp

diff --git a/third_party/WebKit/Source/core/testing/DummyModulator.cpp b/third_party/WebKit/Source/core/testing/DummyModulator.cpp

index e5dcd6994e659b00dd9b73001bda9ba385696fac..4d85797be3d1c72f887a79d9babf21a8d4dd2b18 100644

--- a/third_party/WebKit/Source/core/testing/DummyModulator.cpp

+++ b/third_party/WebKit/Source/core/testing/DummyModulator.cpp

@@ -91,6 +91,10 @@ void DummyModulator::FetchNewSingleModule(const ModuleScriptFetchRequest&,

NOTREACHED();

}

+bool DummyModulator::IsContextValid() {

+ return true;

ScriptModule DummyModulator::CompileModule(const String& script,

const String& url_str,

AccessControlStatus) {