third_party/WebKit/Source/core/dom/Modulator.h - Issue 2886593002: [ES6 modules] ModuleTreeLinker::Instantiate shouldn't proceed on invalid context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Modulator.h

Issue 2886593002: [ES6 modules] ModuleTreeLinker::Instantiate shouldn't proceed on invalid context (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Modulator.h

diff --git a/third_party/WebKit/Source/core/dom/Modulator.h b/third_party/WebKit/Source/core/dom/Modulator.h

index 2e6260fefd3952a3c112dbc8210f8d1b39f3d1fb..ee04ef96d5d4bccbb720d77722b72c5f5dd400b3 100644

--- a/third_party/WebKit/Source/core/dom/Modulator.h

+++ b/third_party/WebKit/Source/core/dom/Modulator.h

@@ -99,6 +99,8 @@ class CORE_EXPORT Modulator : public GarbageCollectedFinalized<Modulator>,

static KURL ResolveModuleSpecifier(const String& module_request,

const KURL& base_url);

+ virtual bool IsContextValid() = 0;

virtual ScriptModule CompileModule(const String& script,

const String& url_str,

AccessControlStatus) = 0;