ios/web/public/test/earl_grey/js_test_util.h - Issue 2886573002: [ObjC ARC] Converts ios/web:earl_grey_test_support to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/test/earl_grey/js_test_util.h

Issue 2886573002: [ObjC ARC] Converts ios/web:earl_grey_test_support to ARC. (Closed)

Patch Set: autoreleasing Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/public/test/earl_grey/js_test_util.h

diff --git a/ios/web/public/test/earl_grey/js_test_util.h b/ios/web/public/test/earl_grey/js_test_util.h

index 8036e99701cd8366333ca7856382ccc30f3f4e5e..1dfdf80bfa26b94a4077c35e3be1423b186a26c8 100644

--- a/ios/web/public/test/earl_grey/js_test_util.h

+++ b/ios/web/public/test/earl_grey/js_test_util.h

@@ -23,7 +23,7 @@ void WaitUntilWindowIdInjected(WebState* web_state);

// fails with a GREYAssert.

id ExecuteJavaScript(WebState* web_state,

NSString* javascript,

- NSError** out_error);

+ NSError* __autoreleasing* out_error);

baxley 2017/05/16 20:12:48 This is one of the more interesting things I did.

stkhapugin 2017/05/30 13:21:38 This looks right to me.

// Synchronously returns the result of executed JavaScript on interstitial page

// displayed for |web_state|.