Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2886563002: Compute export namespaces for DILL libraries. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -55 lines) Patch
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 2 chunks +20 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_loader.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 5 chunks +38 lines, -3 lines 2 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 2 chunks +52 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 7 months ago (2017-05-15 21:39:11 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2886563002/diff/1/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right): https://codereview.chromium.org/2886563002/diff/1/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart#newcode211 pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:211: /// The [dillTarget] can be used to access ...
3 years, 7 months ago (2017-05-15 21:53:49 UTC) #2
scheglov
https://codereview.chromium.org/2886563002/diff/1/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right): https://codereview.chromium.org/2886563002/diff/1/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart#newcode211 pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:211: /// The [dillTarget] can be used to access libraries ...
3 years, 7 months ago (2017-05-16 17:02:44 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 97cf17c322a1c59b3b22b008a0a283052666e60f (presubmit successful).
3 years, 7 months ago (2017-05-16 17:02:50 UTC) #5
ahe
3 years, 7 months ago (2017-05-24 18:41:35 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698