Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: net/http/http_cache_transaction.cc

Issue 2886483002: Adds a new class HttpCache::Writers for multiple cache transactions reading from the network. (Closed)
Patch Set: Comment changed. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache_transaction.h ('k') | net/http/http_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache_transaction.cc
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc
index 10b6d9136c7b83246b80e84c002bda02a6553519..d84194f0444fcd83fa25d6b338f4ac8464987145 100644
--- a/net/http/http_cache_transaction.cc
+++ b/net/http/http_cache_transaction.cc
@@ -580,6 +580,11 @@ size_t HttpCache::Transaction::EstimateMemoryUsage() const {
return 0;
}
+void HttpCache::Transaction::SetSharedWritingFailState(int result) {
+ // TODO(shivanisha): Implement when integrating with HttpCache::Writers.
+ NOTIMPLEMENTED();
+}
+
//-----------------------------------------------------------------------------
// A few common patterns: (Foo* means Foo -> FooComplete)
@@ -1155,8 +1160,8 @@ int HttpCache::Transaction::DoAddToEntry() {
// If headers phase is already done then we are here because of validation not
// matching and creating a new entry. This transaction should be the
- // first transaction of that new entry and thus it should not be subject
- // to any cache lock delays, thus returning early from here.
+ // first transaction of that new entry and thus it will not have cache lock
+ // delays, thus returning early from here.
if (done_headers_create_new_entry_) {
DCHECK_EQ(mode_, WRITE);
TransitionToState(STATE_DONE_HEADERS_ADD_TO_ENTRY_COMPLETE);
« no previous file with comments | « net/http/http_cache_transaction.h ('k') | net/http/http_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698