Adds a new class HttpCache::Writers for multiple cache transactions reading from the network.

net/http/http_transaction_test_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_TRANSACTION_TEST_UTIL_H_
 #define NET_HTTP_HTTP_TRANSACTION_TEST_UTIL_H_
 
 #include "net/http/http_transaction.h"
 
 #include <stdint.h>
@@ skipping 223 matching lines @@
   void SetBeforeHeadersSentCallback(
       const BeforeHeadersSentCallback& callback) override;
 
   int ResumeNetworkStart() override;
 
   void GetConnectionAttempts(ConnectionAttempts* out) const override;
 
   CreateHelper* websocket_handshake_stream_create_helper() {
     return websocket_handshake_stream_create_helper_;
   }
+
+  // Error to return on a future Read call.
+  void SetReadError(int error);

[jkarlin, 2017/06/28 15:50:11]

What calls this? I don't see anything in the CL.

+
   RequestPriority priority() const { return priority_; }
   const HttpRequestInfo* request() const { return request_; }
 
   // Bogus value that will be returned by GetTotalReceivedBytes() if the
   // MockNetworkTransaction was started.
   static const int64_t kTotalReceivedBytes;
   // Bogus value that will be returned by GetTotalSentBytes() if the
   // MockNetworkTransaction was started.
   static const int64_t kTotalSentBytes;
 
@@ skipping 21 matching lines @@
   // NetLog ID of the fake / non-existent underlying socket used by the
   // connection. Requires Start() be passed a NetLogWithSource with a real
   // NetLog to
   // be initialized.
   unsigned int socket_log_id_;
 
   bool done_reading_called_;
 
   CompletionCallback resume_start_callback_;  // used for pause and restart.
 
+  // Error to be returned from Read. If set it will override all Read logic and
+  // simply return the error code (synchronously/asynchronously based on test
+  // mode).

[Randy Smith (Not in Mondays), 2017/06/27 18:49:38]

This is part of the interface, not the implementation, and so should be in
comments above the "private:" line.   And I think this is moderately big deal (I
tentatively put it in the category of "violation of the principle of least
astonishment", meaning I think it'll take other users of this class by surprise
in more cases than not), so I want to make sure it's called out reasonably
loudly.  Could you make sure that this is included in the doc for SetReadError()
and a reference to it put in the comments before AddMockTransaction()?  That's a
bit unfair, since these classes are very much not well documented currently, but
that makes me more worried about making them confusing to use, not less.

Alternatively: I think this same behavior could be done by specifying a
read_handler in the transaction passed to AddMockTransaction().  Any chance you
could simply use that existing interface and not bother with having to document
new behavior?
 

[shivanisha, 2017/06/28 18:02:33]

Added the error code in MockTransaction and now its definition and handling
corresponds well with the existing return_code member. Renamed the existing
member to start_return_code and this one to read_return_code

+  int read_error_;
+
   base::WeakPtrFactory<MockNetworkTransaction> weak_factory_;
 
 };
 
 class MockNetworkLayer : public HttpTransactionFactory,
                          public base::SupportsWeakPtr<MockNetworkLayer> {
  public:
   MockNetworkLayer();
   ~MockNetworkLayer() override;
 
@@ skipping 56 matching lines @@
 
 //-----------------------------------------------------------------------------
 // helpers
 
 // read the transaction completely
 int ReadTransaction(HttpTransaction* trans, std::string* result);
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_TRANSACTION_TEST_UTIL_H_