third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h - Issue 2886453005: Account for border/padding in NG Inline layout algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h

Issue 2886453005: Account for border/padding in NG Inline layout algorithm. (Closed)

Patch Set: Skip some tests becase of crbug.com/713891 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h

diff --git a/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h b/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h

index c81451e7da889547e463864340b1bcc5fb107241..862957a6852a33e3cd9907e71ee7e07bca49bbcf 100644

--- a/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h

+++ b/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_rect.h

@@ -38,6 +38,10 @@ struct CORE_EXPORT NGLogicalRect {

return offset.block_offset + size.block_size;

}

+ NGLogicalOffset InlineStartBlockStartOffset() const {

+ return {InlineStartOffset(), BlockStartOffset()};

+ }

NGLogicalOffset InlineEndBlockStartOffset() const {

return {InlineEndOffset(), BlockStartOffset()};

}