Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2886443003: Minor type inference fixes. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor type inference fixes. - Add num::== and Iterable::where to analyzer mock SDK. - Do not default parameter types to dynamic in BodyBuilder or KernelFormalParameterBuilder. This is now handled by the KernelVariableDeclaration constructor. - Only infer function expression parameter types in strong mode. - Record inferred function expression parameter types to instrumentation. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/51eb5cef4202c8da1cb31126a5d7c55c723b69ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -28 lines) Patch
M pkg/analyzer/test/src/context/mock_sdk.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
A + pkg/front_end/testcases/inference/block_bodied_lambdas_basic_void.dart View 1 chunk +7 lines, -6 lines 0 comments Download
A pkg/front_end/testcases/inference/block_bodied_lambdas_basic_void.dart.direct.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/block_bodied_lambdas_basic_void.dart.outline.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/block_bodied_lambdas_basic_void.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_from_block.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_binary_double_double.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_binary_double_int.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_binary_int_double.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_binary_int_int.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_conditional.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paul Berry
3 years, 7 months ago (2017-05-15 22:00:16 UTC) #3
scheglov
LGTM
3 years, 7 months ago (2017-05-15 22:07:42 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as 51eb5cef4202c8da1cb31126a5d7c55c723b69ff (presubmit successful).
3 years, 7 months ago (2017-05-16 15:42:31 UTC) #6
ahe
3 years, 7 months ago (2017-05-24 18:45:05 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698