Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: components/image_fetcher/core/image_fetcher_impl.cc

Issue 2886443002: [Doodle] Move image fetching from LogoBridge to DoodleService (Closed)
Patch Set: comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/image_fetcher/core/image_fetcher_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/image_fetcher/core/image_fetcher_impl.cc
diff --git a/components/image_fetcher/core/image_fetcher_impl.cc b/components/image_fetcher/core/image_fetcher_impl.cc
index 567928c9a6df05e2daadc47bbb5870fc235aa8f4..1cb6d2628854b6cde54417edc8a6fe57d941a935 100644
--- a/components/image_fetcher/core/image_fetcher_impl.cc
+++ b/components/image_fetcher/core/image_fetcher_impl.cc
@@ -66,6 +66,8 @@ void ImageFetcherImpl::StartOrQueueNetworkRequest(
base::Unretained(this), image_url));
} else {
// Request in progress. Register as an interested callback.
+ // TODO(treib,markusheintz): We're not guaranteed that the ID also matches.
+ // We probably have to store them all.
it->second.callbacks.push_back(callback);
}
}
« no previous file with comments | « components/image_fetcher/core/image_fetcher_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698