Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: components/image_fetcher/core/image_fetcher_impl.h

Issue 2886443002: [Doodle] Move image fetching from LogoBridge to DoodleService (Closed)
Patch Set: build Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/image_fetcher/core/image_fetcher_impl.h
diff --git a/components/image_fetcher/core/image_fetcher_impl.h b/components/image_fetcher/core/image_fetcher_impl.h
index 697217c7f791d5afd91e8de0328f2bda50d07de7..ef032ff033aadb33525ca379fc52cdc5a1a525f1 100644
--- a/components/image_fetcher/core/image_fetcher_impl.h
+++ b/components/image_fetcher/core/image_fetcher_impl.h
@@ -30,7 +30,7 @@ class URLRequestContextGetter;
namespace image_fetcher {
// The standard (non-test) implementation of ImageFetcher.
-class ImageFetcherImpl : public image_fetcher::ImageFetcher {
fhorschig 2017/05/15 13:54:35 Why? Shouldn't it work without image_fetcher:: whe
Marc Treib 2017/05/15 14:25:22 Exactly, which is why I removed the "image_fetcher
+class ImageFetcherImpl : public ImageFetcher {
public:
ImageFetcherImpl(std::unique_ptr<ImageDecoder> image_decoder,
net::URLRequestContextGetter* url_request_context);

Powered by Google App Engine
This is Rietveld 408576698