chrome/browser/engagement/site_engagement_service_unittest.cc - Issue 2886433002: [Android] Adding content settings provider for notification channels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 2886433002: [Android] Adding content settings provider for notification channels (Closed)

Patch Set: Improve comment and fixup site engagement service test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_service_unittest.cc

diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc

index 740e9c14982c0655bd690454bc8576145bd46bfb..e029822cce8e9eea1353118cc04db2077e009101 100644

--- a/chrome/browser/engagement/site_engagement_service_unittest.cc

+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc

@@ -557,7 +557,7 @@ TEST_F(SiteEngagementServiceTest, NotificationPermission) {

settings_map->SetContentSettingDefaultScope(

url3, GURL(), CONTENT_SETTINGS_TYPE_NOTIFICATIONS,

- content_settings::ResourceIdentifier(), CONTENT_SETTING_ASK);

+ content_settings::ResourceIdentifier(), CONTENT_SETTING_DEFAULT);

EXPECT_EQ(5, service_->GetScore(url1));

EXPECT_EQ(0, service_->GetScore(url2));