Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: chrome/browser/notifications/notification_channels_provider_android_unittest.cc

Issue 2886433002: [Android] Adding content settings provider for notification channels (Closed)
Patch Set: Use Origin.Serialize instead of GURL.spec() Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_channels_provider_android_unittest.cc
diff --git a/chrome/browser/notifications/notification_channels_provider_android_unittest.cc b/chrome/browser/notifications/notification_channels_provider_android_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..26f41f9221c1935b1df0f13025d92f10e7d2a694
--- /dev/null
+++ b/chrome/browser/notifications/notification_channels_provider_android_unittest.cc
@@ -0,0 +1,131 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/notification_channels_provider_android.h"
+
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
+#include "components/content_settings/core/browser/content_settings_pref.h"
+#include "components/content_settings/core/common/content_settings_pattern.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+using ::testing::Return;
+
+namespace {
+const char kTestOrigin[] = "https://example.com";
+} // namespace
+
+class MockNotificationChannelsBridge
+ : public NotificationChannelsProviderAndroid::NotificationChannelsBridge {
+ public:
+ ~MockNotificationChannelsBridge() = default;
+ MOCK_METHOD0(ShouldUseChannelSettings, bool());
+ MOCK_METHOD2(CreateChannel, void(const std::string&, bool));
+ MOCK_METHOD1(GetChannelStatus, NotificationChannelStatus(const std::string&));
+ MOCK_METHOD1(DeleteChannel, void(const std::string&));
+};
+
+class NotificationChannelsProviderAndroidTest : public testing::Test {
+ public:
+ NotificationChannelsProviderAndroidTest()
+ : mock_bridge_(new MockNotificationChannelsBridge()) {}
+ ~NotificationChannelsProviderAndroidTest() {
+ channels_provider_->ShutdownOnUIThread();
+ }
+
+ protected:
+ // No leak because ownership is passed to channels_provider_ in constructor.
+ MockNotificationChannelsBridge* mock_bridge_;
+ std::unique_ptr<NotificationChannelsProviderAndroid> channels_provider_;
+ void InitChannelsProvider(bool should_use_channels) {
+ EXPECT_CALL(*mock_bridge_, ShouldUseChannelSettings())
+ .WillOnce(Return(should_use_channels));
+ // Can't use base::MakeUnique because the provider's constructor is private.
+ channels_provider_ =
+ base::WrapUnique(new NotificationChannelsProviderAndroid(
+ base::WrapUnique(mock_bridge_)));
+ }
+};
+
+TEST_F(NotificationChannelsProviderAndroidTest,
+ SetWebsiteSettingWhenChannelsShouldNotBeUsed_NoopAndReturnsFalse) {
+ this->InitChannelsProvider(false /* should_use_channels */);
+ bool result = channels_provider_->SetWebsiteSetting(
+ ContentSettingsPattern::FromString(kTestOrigin), ContentSettingsPattern(),
+ CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),
+ new base::Value(CONTENT_SETTING_BLOCK));
+
+ EXPECT_FALSE(result);
+}
+
+TEST_F(NotificationChannelsProviderAndroidTest,
+ SetWebsiteSettingAllowedWhenChannelUnavailable_CreatesEnabledChannel) {
+ InitChannelsProvider(true /* should_use_channels */);
+ EXPECT_CALL(*mock_bridge_, GetChannelStatus(kTestOrigin))
+ .WillOnce(Return(NotificationChannelStatus::UNAVAILABLE));
+ EXPECT_CALL(*mock_bridge_, CreateChannel(kTestOrigin, true /* enabled */));
+
+ bool result = channels_provider_->SetWebsiteSetting(
+ ContentSettingsPattern::FromString(kTestOrigin), ContentSettingsPattern(),
+ CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),
+ new base::Value(CONTENT_SETTING_ALLOW));
+
+ EXPECT_TRUE(result);
+}
+
+TEST_F(NotificationChannelsProviderAndroidTest,
+ SetWebsiteSettingBlockedWhenChannelUnavailable_CreatesDisabledChannel) {
+ InitChannelsProvider(true /* should_use_channels */);
+ EXPECT_CALL(*mock_bridge_, GetChannelStatus(kTestOrigin))
+ .WillOnce(Return(NotificationChannelStatus::UNAVAILABLE));
+ EXPECT_CALL(*mock_bridge_, CreateChannel(kTestOrigin, false /* enabled */));
+
+ bool result = channels_provider_->SetWebsiteSetting(
+ ContentSettingsPattern::FromString(kTestOrigin), ContentSettingsPattern(),
+ CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),
+ new base::Value(CONTENT_SETTING_BLOCK));
+
+ EXPECT_TRUE(result);
+}
+
+TEST_F(NotificationChannelsProviderAndroidTest,
+ SetWebsiteSettingAllowedWhenChannelAllowed_NoopAndReturnsTrue) {
+ InitChannelsProvider(true /* should_use_channels */);
+ EXPECT_CALL(*mock_bridge_, GetChannelStatus(kTestOrigin))
+ .WillOnce(Return(NotificationChannelStatus::ENABLED));
+
+ bool result = channels_provider_->SetWebsiteSetting(
+ ContentSettingsPattern::FromString(kTestOrigin), ContentSettingsPattern(),
+ CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),
+ new base::Value(CONTENT_SETTING_ALLOW));
+
+ EXPECT_TRUE(result);
+}
+
+TEST_F(NotificationChannelsProviderAndroidTest,
+ SetWebsiteSettingBlockedWhenChannelBlocked_NoopAndReturnsTrue) {
+ InitChannelsProvider(true /* should_use_channels */);
+ EXPECT_CALL(*mock_bridge_, GetChannelStatus(kTestOrigin))
+ .WillOnce(Return(NotificationChannelStatus::BLOCKED));
+
+ bool result = channels_provider_->SetWebsiteSetting(
+ ContentSettingsPattern::FromString(kTestOrigin), ContentSettingsPattern(),
+ CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(),
+ new base::Value(CONTENT_SETTING_BLOCK));
+
+ EXPECT_TRUE(result);
+}
+
+TEST_F(NotificationChannelsProviderAndroidTest,
+ SetWebsiteSettingDefault_DeletesChannelAndReturnsTrue) {
+ InitChannelsProvider(true /* should_use_channels */);
+ EXPECT_CALL(*mock_bridge_, DeleteChannel(kTestOrigin));
+ bool result = channels_provider_->SetWebsiteSetting(
+ ContentSettingsPattern::FromString(kTestOrigin), ContentSettingsPattern(),
+ CONTENT_SETTINGS_TYPE_NOTIFICATIONS, std::string(), nullptr);
+
+ EXPECT_TRUE(result);
+}

Powered by Google App Engine
This is Rietveld 408576698