Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4839)

Unified Diff: chrome/browser/notifications/notification_channels_provider_android.cc

Issue 2886433002: [Android] Adding content settings provider for notification channels (Closed)
Patch Set: Use Origin.Serialize instead of GURL.spec() Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_channels_provider_android.cc
diff --git a/chrome/browser/notifications/notification_channels_provider_android.cc b/chrome/browser/notifications/notification_channels_provider_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a524eed558c7514181d6ccc7a0e2335bb74cbb1f
--- /dev/null
+++ b/chrome/browser/notifications/notification_channels_provider_android.cc
@@ -0,0 +1,137 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/notification_channels_provider_android.h"
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_string.h"
+#include "base/logging.h"
+#include "base/strings/string_util.h"
+#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/content_settings/core/browser/content_settings_details.h"
+#include "components/content_settings/core/browser/content_settings_utils.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/content_settings/core/common/content_settings.h"
+#include "components/content_settings/core/common/content_settings_pattern.h"
+#include "jni/NotificationSettingsBridge_jni.h"
+#include "url/gurl.h"
+#include "url/origin.h"
+#include "url/url_constants.h"
+
+using base::android::AttachCurrentThread;
+using base::android::ConvertUTF8ToJavaString;
+using base::android::ScopedJavaLocalRef;
+
+namespace {
+
+class NotificationChannelsBridgeImpl
+ : public NotificationChannelsProviderAndroid::NotificationChannelsBridge {
+ public:
+ NotificationChannelsBridgeImpl() = default;
+ ~NotificationChannelsBridgeImpl() override = default;
+
+ bool ShouldUseChannelSettings() override {
+ return Java_NotificationSettingsBridge_shouldUseChannelSettings(
+ AttachCurrentThread());
+ }
+
+ void CreateChannel(const std::string& origin, bool enabled) override {
+ JNIEnv* env = AttachCurrentThread();
+ Java_NotificationSettingsBridge_createChannel(
+ env, ConvertUTF8ToJavaString(env, origin), enabled);
+ }
+
+ NotificationChannelStatus GetChannelStatus(
+ const std::string& origin) override {
+ JNIEnv* env = AttachCurrentThread();
+ return static_cast<NotificationChannelStatus>(
+ Java_NotificationSettingsBridge_getChannelStatus(
+ env, ConvertUTF8ToJavaString(env, origin)));
+ }
+
+ void DeleteChannel(const std::string& origin) override {
+ JNIEnv* env = AttachCurrentThread();
+ Java_NotificationSettingsBridge_deleteChannel(
+ env, ConvertUTF8ToJavaString(env, origin));
+ }
+};
+
+} // anonymous namespace
+
+NotificationChannelsProviderAndroid::NotificationChannelsProviderAndroid()
+ : NotificationChannelsProviderAndroid(
+ base::MakeUnique<NotificationChannelsBridgeImpl>()) {}
+
+NotificationChannelsProviderAndroid::NotificationChannelsProviderAndroid(
+ std::unique_ptr<NotificationChannelsBridge> bridge)
+ : bridge_(std::move(bridge)),
+ should_use_channels_(bridge_->ShouldUseChannelSettings()) {}
+
+NotificationChannelsProviderAndroid::~NotificationChannelsProviderAndroid() =
+ default;
+
+std::unique_ptr<content_settings::RuleIterator>
+NotificationChannelsProviderAndroid::GetRuleIterator(
+ ContentSettingsType content_type,
+ const content_settings::ResourceIdentifier& resource_identifier,
+ bool incognito) const {
+ // TODO(crbug.com/700377) return rule iterator over all channels
+ return nullptr;
+}
+
+bool NotificationChannelsProviderAndroid::SetWebsiteSetting(
+ const ContentSettingsPattern& primary_pattern,
+ const ContentSettingsPattern& secondary_pattern,
+ ContentSettingsType content_type,
+ const content_settings::ResourceIdentifier& resource_identifier,
+ base::Value* value) {
+ if (content_type != CONTENT_SETTINGS_TYPE_NOTIFICATIONS ||
+ !should_use_channels_) {
+ return false;
+ }
+ if (primary_pattern.MatchesAllHosts()) {
+ // This provider only handles settings for specific origins.
Peter Beverloo 2017/06/05 15:11:31 nit: I'd place the comment above the conditional a
awdf 2017/06/05 17:06:56 Done.
+ return false;
+ }
+ GURL primary_url = GURL(primary_pattern.ToString());
+ url::Origin origin = url::Origin(GURL(primary_pattern.ToString()));
+ DCHECK(!origin.unique());
+ const std::string origin_string = origin.Serialize();
+ ContentSetting setting = content_settings::ValueToContentSetting(value);
+ switch (setting) {
+ case CONTENT_SETTING_ALLOW:
+ case CONTENT_SETTING_BLOCK: {
+ auto channel_status = bridge_->GetChannelStatus(origin_string);
+ if (channel_status == NotificationChannelStatus::UNAVAILABLE) {
+ bridge_->CreateChannel(origin_string,
+ setting == CONTENT_SETTING_ALLOW /* enabled */);
+ } else {
+ DCHECK(!(setting == CONTENT_SETTING_ALLOW &&
+ channel_status == NotificationChannelStatus::BLOCKED));
+ DCHECK(!(setting == CONTENT_SETTING_BLOCK &&
+ channel_status == NotificationChannelStatus::ENABLED));
+ }
+ break;
+ }
+ case CONTENT_SETTING_DEFAULT:
+ bridge_->DeleteChannel(origin_string);
+ break;
+ default:
+ // We rely on notification settings being one of ALLOW/BLOCK/DEFAULT.
+ NOTREACHED();
+ break;
+ }
+ return true;
+}
+
+void NotificationChannelsProviderAndroid::ClearAllContentSettingsRules(
+ ContentSettingsType content_type) {
+ // TODO(crbug.com/700377): If |content_type| == NOTIFICATIONS, delete
+ // all channels.
+}
+
+void NotificationChannelsProviderAndroid::ShutdownOnUIThread() {
+ RemoveAllObservers();
+}

Powered by Google App Engine
This is Rietveld 408576698