Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6251)

Unified Diff: chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc

Issue 2886363002: Flip the kRequireSecureOriginsForPepperMediaRequests to enabled by default (Closed)
Patch Set: Flip the kRequireSecureOriginsForPepperMediaRequests to enabled by default Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
diff --git a/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc b/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
index 0abf365d2e05d53c736ac0369e786e57d9fe99de..fd9bc218de0eef6a5b2539f4d6094815fc912237 100644
--- a/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
+++ b/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
@@ -851,24 +851,34 @@ IN_PROC_BROWSER_TEST_P(MediaStreamDevicesControllerTest,
SetPromptResponseType(PermissionRequestManager::ACCEPT_ALL);
- RequestPermissions(
- GetWebContents(),
- CreateRequestWithType(example_audio_id(), std::string(),
- content::MEDIA_OPEN_DEVICE_PEPPER_ONLY),
- base::Bind(&MediaStreamDevicesControllerTest::OnMediaStreamResponse,
- base::Unretained(this)));
- ASSERT_EQ(2u, TotalPromptRequestCount());
+ {
+ // Test that with the kRequireSecureOriginsForPepperMediaRequests flag
+ // disabled that permission will be denied. TODO(raymes): Remove this when
+ // crbug.com/526324 is fixed.
+ base::test::ScopedFeatureList scoped_feature_list;
+ if (static_cast<TestType>(GetParam()) ==
+ TestType::TEST_WITH_GROUPED_MEDIA_REQUESTS) {
+ scoped_feature_list.InitWithFeatures(
+ {features::kUsePermissionManagerForMediaRequests},
+ {features::kRequireSecureOriginsForPepperMediaRequests});
+ } else {
+ scoped_feature_list.InitWithFeatures(
+ {}, {features::kRequireSecureOriginsForPepperMediaRequests});
+ }
+ RequestPermissions(
+ GetWebContents(),
+ CreateRequestWithType(example_audio_id(), std::string(),
+ content::MEDIA_OPEN_DEVICE_PEPPER_ONLY),
+ base::Bind(&MediaStreamDevicesControllerTest::OnMediaStreamResponse,
+ base::Unretained(this)));
+ ASSERT_EQ(2u, TotalPromptRequestCount());
- ASSERT_EQ(content::MEDIA_DEVICE_OK, media_stream_result());
- ASSERT_TRUE(CheckDevicesListContains(content::MEDIA_DEVICE_AUDIO_CAPTURE));
- ASSERT_FALSE(CheckDevicesListContains(content::MEDIA_DEVICE_VIDEO_CAPTURE));
+ ASSERT_EQ(content::MEDIA_DEVICE_OK, media_stream_result());
+ ASSERT_TRUE(CheckDevicesListContains(content::MEDIA_DEVICE_AUDIO_CAPTURE));
+ ASSERT_FALSE(CheckDevicesListContains(content::MEDIA_DEVICE_VIDEO_CAPTURE));
+ }
- // Test that with the kRequireSecureOriginsForPepperMediaRequests flag enabled
- // that permission will be denied.
ResetPromptCounters();
- base::test::ScopedFeatureList scoped_feature_list;
- scoped_feature_list.InitAndEnableFeature(
- features::kRequireSecureOriginsForPepperMediaRequests);
RequestPermissions(
GetWebContents(),
CreateRequestWithType(example_audio_id(), example_video_id(),

Powered by Google App Engine
This is Rietveld 408576698