Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html

Issue 2886353002: Milo: Add an option to hide green steps (Closed)
Patch Set: Retrain Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
diff --git a/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html b/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
index 7ee8d3364909a9dcda1e693cca77f55e7d578c56..33598006cfe85645583be083fbee2200dadf89e0 100644
--- a/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
+++ b/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
@@ -105,16 +105,21 @@
<h2>Steps and Logfiles:</h2>
- <input type="checkbox" id="showHidden">
- <label for="showHidden">Show hidden <span id="numHidden"></span></label>
- <ol id="steps" class="hide">
+ Show:
+ <input type="radio" name="hider" id="showAll">
+ <label for="showAll">All</label>
+ <input type="radio" name="hider" id="showStandard" checked>
+ <label for="showStandard">Standard</label>
+ <input type="radio" name="hider" id="showInteresting">
+ <label for="showInteresting">Interesting Only</label>
+ <ol id="steps" class="standard">
- <li class="verbosity-Normal">
+ <li class="verbosity-Interesting">
<div class="status-Failure result">
<b>steps</b>
<span style="float:right"
@@ -177,24 +182,25 @@
</div>
<script language="javascript">
$(document).ready(function() {
- var check = function(checked) {
- var things = $("#steps");
- if (checked) {
- $("#steps").removeClass("hide");
- } else {
- $("#steps").addClass("hide");
- }
- var numHidden = $(".verbosity-Hidden").length;
- if (numHidden > 0) {
- $("#numHidden").text("(" + numHidden + " hidden)");
- } else {
- $("#numHidden").text("");
- }
- };
- check($("#showHidden").is(":checked"));
- $("#showHidden").click(function(e) {
- check($(this).is(":checked"));
+ var check = function(className) {
+ $("#steps").removeClass("all standard interesting").addClass(className)
+ }
+
+ $("#showInteresting").click(function(e) {
+ check("interesting");
+ });
+ $("#showStandard").click(function(e) {
+ check("standard");
+ });
+ $("#showAll").click(function(e) {
+ check("all");
+ });
+
+ $("input[name='hider']").each(function(){
+ if ($(this).prop("checked")) {
+ $(this).click();
+ }
});
});
</script>

Powered by Google App Engine
This is Rietveld 408576698