Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: milo/appengine/buildbot/build.go

Issue 2886353002: Milo: Add an option to hide green steps (Closed)
Patch Set: Retrain Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | milo/appengine/buildbot/expectations/newline.1234.build.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/build.go
diff --git a/milo/appengine/buildbot/build.go b/milo/appengine/buildbot/build.go
index 5f0b92f19d184d867e89981ad33f97e4f5381581..07f48746057f51eeb24c87d0268bc6c6bc989a4f 100644
--- a/milo/appengine/buildbot/build.go
+++ b/milo/appengine/buildbot/build.go
@@ -226,6 +226,11 @@ func components(b *buildbotBuild) (result []*resp.BuildComponent) {
}
}
+ // Raise the interesting-ness if the step is not "Success".
+ if bc.Status != resp.Success {
+ bc.Verbosity = resp.Interesting
+ }
+
remainingAliases := stringset.New(len(step.Aliases))
for linkAnchor := range step.Aliases {
remainingAliases.Add(linkAnchor)
« no previous file with comments | « no previous file | milo/appengine/buildbot/expectations/newline.1234.build.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698