Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: content/renderer/render_widget.cc

Issue 288633002: Remove renderer-side tracking of accelerated compositing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on piman;danakj review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget.h ('k') | content/renderer/render_widget_fullscreen_pepper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 3a39f6040cfd57f53cf3290bbbebabee32a87c69..0c1037f3cbe4860e9f5b0363e1c0db3842bd2ffa 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -383,7 +383,6 @@ RenderWidget::RenderWidget(blink::WebPopupType popup_type,
popup_type_(popup_type),
pending_window_rect_count_(0),
suppress_next_char_events_(false),
- is_accelerated_compositing_active_(false),
screen_info_(screen_info),
device_scale_factor_(screen_info_.deviceScaleFactor),
is_threaded_compositing_enabled_(false),
@@ -486,11 +485,8 @@ void RenderWidget::CompleteInit() {
init_complete_ = true;
- if (webwidget_) {
- if (is_threaded_compositing_enabled_ || ForceCompositingModeEnabled()) {
- webwidget_->enterForceCompositingMode(true);
- }
- }
+ if (webwidget_)
+ webwidget_->enterForceCompositingMode(true);
if (compositor_)
StartCompositor();
@@ -784,13 +780,9 @@ void RenderWidget::OnWasShown(bool needs_repainting) {
return;
// Generate a full repaint.
- if (!is_accelerated_compositing_active_) {
- didInvalidateRect(gfx::Rect(size_.width(), size_.height()));
- } else {
- if (compositor_)
- compositor_->SetNeedsForcedRedraw();
- scheduleComposite();
- }
+ if (compositor_)
+ compositor_->SetNeedsForcedRedraw();
+ scheduleComposite();
}
void RenderWidget::OnWasSwappedOut() {
@@ -1172,19 +1164,6 @@ void RenderWidget::AutoResizeCompositor() {
compositor_->setViewportSize(size_, physical_backing_size_);
}
-void RenderWidget::didActivateCompositor() {
- TRACE_EVENT0("gpu", "RenderWidget::didActivateCompositor");
-
- is_accelerated_compositing_active_ = true;
- webwidget_->enterForceCompositingMode(true);
-}
-
-void RenderWidget::didDeactivateCompositor() {
- TRACE_EVENT0("gpu", "RenderWidget::didDeactivateCompositor");
-
- is_accelerated_compositing_active_ = false;
-}
-
void RenderWidget::initializeLayerTreeView() {
compositor_ = RenderWidgetCompositor::Create(
this, is_threaded_compositing_enabled_);
@@ -1485,12 +1464,8 @@ void RenderWidget::OnRepaint(gfx::Size size_to_paint) {
}
set_next_paint_is_repaint_ack();
- if (is_accelerated_compositing_active_ && compositor_) {
+ if (compositor_)
compositor_->SetNeedsRedrawRect(gfx::Rect(size_to_paint));
- } else {
- gfx::Rect repaint_rect(size_to_paint.width(), size_to_paint.height());
- didInvalidateRect(repaint_rect);
- }
}
void RenderWidget::OnSyntheticGestureCompleted() {
@@ -1546,12 +1521,7 @@ void RenderWidget::SetDeviceScaleFactor(float device_scale_factor) {
return;
device_scale_factor_ = device_scale_factor;
-
- if (!is_accelerated_compositing_active_) {
- didInvalidateRect(gfx::Rect(size_.width(), size_.height()));
- } else {
- scheduleComposite();
- }
+ scheduleComposite();
}
void RenderWidget::OnOrientationChange() {
« no previous file with comments | « content/renderer/render_widget.h ('k') | content/renderer/render_widget_fullscreen_pepper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698