Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6300)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 2886253002: mash: remove more shell/shelf WmWindow usage. (Closed)
Patch Set: Fix WmShelf::ForWindow. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
index bcaad78e3829d8cf4dd88e5fdf94514ba2e6b4b0..53b541c0a70acb66806b6c8c5687b5ebf4d5beb0 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
@@ -279,8 +279,7 @@ class ShelfAppBrowserTest : public ExtensionBrowserTest {
// Ensure ash starts the session and creates the shelf and controller.
SessionControllerClient::FlushForTesting();
- shelf_ =
- ash::WmShelf::ForWindow(ash::ShellPort::Get()->GetPrimaryRootWindow());
+ shelf_ = ash::WmShelf::ForWindow(ash::Shell::GetPrimaryRootWindow());
model_ = ash::Shell::Get()->shelf_model();
controller_ = ChromeLauncherController::instance();
ASSERT_TRUE(controller_);
@@ -377,8 +376,7 @@ class ShelfAppBrowserTest : public ExtensionBrowserTest {
int index = model_->GetItemIndexForType(ash::TYPE_BROWSER_SHORTCUT);
DCHECK_GE(index, 0);
ash::ShelfItem item = model_->items()[index];
- ash::WmShelf* shelf =
- ash::WmShelf::ForWindow(ash::WmWindow::Get(CurrentContext()));
+ ash::WmShelf* shelf = ash::WmShelf::ForWindow(CurrentContext());
std::unique_ptr<LauncherContextMenu> menu(
LauncherContextMenu::Create(controller_, &item, shelf));
return menu;
@@ -1904,7 +1902,7 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, MultiDisplayBasicDragAndDrop) {
DCHECK_EQ(ash::Shell::GetAllRootWindows().size(), 2U);
aura::Window* secondary_root_window = ash::Shell::GetAllRootWindows()[1];
ash::WmShelf* secondary_shelf =
- ash::WmShelf::ForWindow(ash::WmWindow::Get(secondary_root_window));
+ ash::WmShelf::ForWindow(secondary_root_window);
ui::test::EventGenerator generator(secondary_root_window, gfx::Point());
ash::test::ShelfViewTestAPI test(secondary_shelf->GetShelfViewForTesting());

Powered by Google App Engine
This is Rietveld 408576698