Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: ash/shell.h

Issue 2886253002: mash: remove more shell/shelf WmWindow usage. (Closed)
Patch Set: Sync and rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_SHELL_H_ 5 #ifndef ASH_SHELL_H_
6 #define ASH_SHELL_H_ 6 #define ASH_SHELL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 229
230 // Returns the primary root Window. The primary root Window is the one that 230 // Returns the primary root Window. The primary root Window is the one that
231 // has a launcher. 231 // has a launcher.
232 static aura::Window* GetPrimaryRootWindow(); 232 static aura::Window* GetPrimaryRootWindow();
233 233
234 // Returns the root window that newly created windows should be added to. 234 // Returns the root window that newly created windows should be added to.
235 // Value can be temporarily overridden using ScopedRootWindowForNewWindows. 235 // Value can be temporarily overridden using ScopedRootWindowForNewWindows.
236 // NOTE: this returns the root, newly created window should be added to the 236 // NOTE: this returns the root, newly created window should be added to the
237 // appropriate container in the returned window. 237 // appropriate container in the returned window.
238 static aura::Window* GetRootWindowForNewWindows(); 238 static aura::Window* GetRootWindowForNewWindows();
239 static WmWindow* GetWmRootWindowForNewWindows();
James Cook 2017/05/17 23:41:49 Hooray!
msw 2017/05/18 20:28:00 Acknowledged.
240 239
241 // Returns all root windows. 240 // Returns all root windows.
242 static aura::Window::Windows GetAllRootWindows(); 241 static aura::Window::Windows GetAllRootWindows();
243 242
244 static aura::Window* GetContainer(aura::Window* root_window, 243 static aura::Window* GetContainer(aura::Window* root_window,
245 int container_id); 244 int container_id);
246 static const aura::Window* GetContainer(const aura::Window* root_window, 245 static const aura::Window* GetContainer(const aura::Window* root_window,
247 int container_id); 246 int container_id);
248 247
249 // TODO(sky): move this and WindowManagerClient into ShellMash that is owned 248 // TODO(sky): move this and WindowManagerClient into ShellMash that is owned
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 506
508 UserMetricsRecorder* metrics() { return user_metrics_recorder_.get(); } 507 UserMetricsRecorder* metrics() { return user_metrics_recorder_.get(); }
509 508
510 void SetTouchHudProjectionEnabled(bool enabled); 509 void SetTouchHudProjectionEnabled(bool enabled);
511 510
512 bool is_touch_hud_projection_enabled() const { 511 bool is_touch_hud_projection_enabled() const {
513 return is_touch_hud_projection_enabled_; 512 return is_touch_hud_projection_enabled_;
514 } 513 }
515 514
516 // NOTE: Prefer ScopedRootWindowForNewWindows when setting temporarily. 515 // NOTE: Prefer ScopedRootWindowForNewWindows when setting temporarily.
517 void set_root_window_for_new_windows(WmWindow* root) { 516 void set_root_window_for_new_windows(aura::Window* root) {
518 root_window_for_new_windows_ = root; 517 root_window_for_new_windows_ = root;
519 } 518 }
520 519
521 // Creates instance of FirstRunHelper. Caller is responsible for deleting 520 // Creates instance of FirstRunHelper. Caller is responsible for deleting
522 // returned object. 521 // returned object.
523 ash::FirstRunHelper* CreateFirstRunHelper(); 522 ash::FirstRunHelper* CreateFirstRunHelper();
524 523
525 // Creates the ShelfView for each display and populates it with items. 524 // Creates the ShelfView for each display and populates it with items.
526 // Called after the user session is active and profile is available. 525 // Called after the user session is active and profile is available.
527 void CreateShelfView(); 526 void CreateShelfView();
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 804
806 // Cursor may be hidden on certain key events in Chrome OS, whereas we never 805 // Cursor may be hidden on certain key events in Chrome OS, whereas we never
807 // hide the cursor on Windows. 806 // hide the cursor on Windows.
808 std::unique_ptr<::wm::CursorManager> cursor_manager_; 807 std::unique_ptr<::wm::CursorManager> cursor_manager_;
809 808
810 // For testing only: simulate that a modal window is open 809 // For testing only: simulate that a modal window is open
811 bool simulate_modal_window_open_for_testing_; 810 bool simulate_modal_window_open_for_testing_;
812 811
813 bool is_touch_hud_projection_enabled_; 812 bool is_touch_hud_projection_enabled_;
814 813
815 // See comment for GetWmRootWindowForNewWindows(). 814 // See comment for GetRootWindowForNewWindows().
816 WmWindow* root_window_for_new_windows_ = nullptr; 815 aura::Window* root_window_for_new_windows_ = nullptr;
817 WmWindow* scoped_root_window_for_new_windows_ = nullptr; 816 aura::Window* scoped_root_window_for_new_windows_ = nullptr;
818 817
819 // Injected content::GPUDataManager support. 818 // Injected content::GPUDataManager support.
820 std::unique_ptr<GPUSupport> gpu_support_; 819 std::unique_ptr<GPUSupport> gpu_support_;
821 820
822 std::unique_ptr<ImmersiveHandlerFactoryAsh> immersive_handler_factory_; 821 std::unique_ptr<ImmersiveHandlerFactoryAsh> immersive_handler_factory_;
823 822
824 std::unique_ptr<AppListDelegateImpl> app_list_delegate_impl_; 823 std::unique_ptr<AppListDelegateImpl> app_list_delegate_impl_;
825 824
826 base::ObserverList<ShellObserver> shell_observers_; 825 base::ObserverList<ShellObserver> shell_observers_;
827 826
828 scoped_refptr<base::SequencedWorkerPool> blocking_pool_; 827 scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
829 828
830 DISALLOW_COPY_AND_ASSIGN(Shell); 829 DISALLOW_COPY_AND_ASSIGN(Shell);
831 }; 830 };
832 831
833 } // namespace ash 832 } // namespace ash
834 833
835 #endif // ASH_SHELL_H_ 834 #endif // ASH_SHELL_H_
OLDNEW
« ash/shelf/shelf_widget_unittest.cc ('K') | « ash/shelf/wm_shelf.cc ('k') | ash/shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698