Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc

Issue 2886253002: mash: remove more shell/shelf WmWindow usage. (Closed)
Patch Set: Fix WmShelf::ForWindow. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/scoped_root_window_for_new_windows.h" 5 #include "ash/scoped_root_window_for_new_windows.h"
6 #include "ash/shell.h" 6 #include "ash/shell.h"
7 #include "ash/shell_port.h"
8 #include "ash/test/ash_test_base.h" 7 #include "ash/test/ash_test_base.h"
9 #include "ash/wm/window_positioner.h" 8 #include "ash/wm/window_positioner.h"
10 #include "ash/wm/window_resizer.h" 9 #include "ash/wm/window_resizer.h"
11 #include "ash/wm/window_state.h" 10 #include "ash/wm/window_state.h"
12 #include "ash/wm/window_state_aura.h" 11 #include "ash/wm/window_state_aura.h"
13 #include "ash/wm_window.h" 12 #include "ash/wm_window.h"
14 #include "base/memory/ptr_util.h" 13 #include "base/memory/ptr_util.h"
15 #include "build/build_config.h" 14 #include "build/build_config.h"
16 #include "chrome/browser/ui/ash/ash_util.h" 15 #include "chrome/browser/ui/ash/ash_util.h"
17 #include "chrome/browser/ui/browser.h" 16 #include "chrome/browser/ui/browser.h"
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 // Test that the target root window is used as the destination of 816 // Test that the target root window is used as the destination of
818 // the non browser window. This differ from PersistedBoundsCase 817 // the non browser window. This differ from PersistedBoundsCase
819 // in that this uses real ash shell implementations + StateProvider 818 // in that this uses real ash shell implementations + StateProvider
820 // TargetDisplayProvider, rather than mocks. 819 // TargetDisplayProvider, rather than mocks.
821 TEST_F(WindowSizerAshTest, DefaultBoundsInTargetDisplay) { 820 TEST_F(WindowSizerAshTest, DefaultBoundsInTargetDisplay) {
822 if (!ash_util::ShouldOpenAshOnStartup()) 821 if (!ash_util::ShouldOpenAshOnStartup())
823 return; 822 return;
824 UpdateDisplay("500x500,600x600"); 823 UpdateDisplay("500x500,600x600");
825 824
826 // By default windows are placed on the primary display. 825 // By default windows are placed on the primary display.
827 ash::WmWindow* first_root = ash::ShellPort::Get()->GetAllRootWindows()[0]; 826 aura::Window* first_root = ash::Shell::GetAllRootWindows()[0];
828 EXPECT_EQ(first_root, ash::Shell::GetWmRootWindowForNewWindows()); 827 EXPECT_EQ(first_root, ash::Shell::GetRootWindowForNewWindows());
829 gfx::Rect bounds; 828 gfx::Rect bounds;
830 ui::WindowShowState show_state; 829 ui::WindowShowState show_state;
831 WindowSizer::GetBrowserWindowBoundsAndShowState(std::string(), gfx::Rect(), 830 WindowSizer::GetBrowserWindowBoundsAndShowState(std::string(), gfx::Rect(),
832 NULL, &bounds, &show_state); 831 NULL, &bounds, &show_state);
833 EXPECT_TRUE(first_root->GetBoundsInScreen().Contains(bounds)); 832 EXPECT_TRUE(first_root->GetBoundsInScreen().Contains(bounds));
834 833
835 { 834 {
836 // When the second display is active new windows are placed there. 835 // When the second display is active new windows are placed there.
837 ash::WmWindow* second_root = ash::ShellPort::Get()->GetAllRootWindows()[1]; 836 aura::Window* second_root = ash::Shell::GetAllRootWindows()[1];
838 ash::ScopedRootWindowForNewWindows tmp(second_root); 837 ash::ScopedRootWindowForNewWindows tmp(second_root);
839 gfx::Rect bounds; 838 gfx::Rect bounds;
840 ui::WindowShowState show_state; 839 ui::WindowShowState show_state;
841 WindowSizer::GetBrowserWindowBoundsAndShowState( 840 WindowSizer::GetBrowserWindowBoundsAndShowState(
842 std::string(), 841 std::string(),
843 gfx::Rect(), 842 gfx::Rect(),
844 NULL, 843 NULL,
845 &bounds, 844 &bounds,
846 &show_state); 845 &show_state);
847 EXPECT_TRUE(second_root->GetBoundsInScreen().Contains(bounds)); 846 EXPECT_TRUE(second_root->GetBoundsInScreen().Contains(bounds));
(...skipping 14 matching lines...) Expand all
862 EXPECT_EQ( 861 EXPECT_EQ(
863 ui::SHOW_STATE_DEFAULT, 862 ui::SHOW_STATE_DEFAULT,
864 GetWindowShowState(ui::SHOW_STATE_DEFAULT, ui::SHOW_STATE_NORMAL, BOTH, 863 GetWindowShowState(ui::SHOW_STATE_DEFAULT, ui::SHOW_STATE_NORMAL, BOTH,
865 trusted_popup.get(), p1280x1024, p1600x1200)); 864 trusted_popup.get(), p1280x1024, p1600x1200));
866 // A popup that is sized to occupy the whole work area has default state. 865 // A popup that is sized to occupy the whole work area has default state.
867 EXPECT_EQ( 866 EXPECT_EQ(
868 ui::SHOW_STATE_DEFAULT, 867 ui::SHOW_STATE_DEFAULT,
869 GetWindowShowState(ui::SHOW_STATE_DEFAULT, ui::SHOW_STATE_NORMAL, BOTH, 868 GetWindowShowState(ui::SHOW_STATE_DEFAULT, ui::SHOW_STATE_NORMAL, BOTH,
870 trusted_popup.get(), p1600x1200, p1600x1200)); 869 trusted_popup.get(), p1600x1200, p1600x1200));
871 } 870 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698