Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2886113002: Introduce WebPluginContainerBase to abstract WebPluginContainerImpl. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index bd26c8f111d096fd0499666de9c8e752dbbc304d..c79411f624b46d380f2a21a996ae61368df5c3d1 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -41,6 +41,7 @@
#include "core/events/UIEventWithKeyState.h"
#include "core/events/WebInputEventConversion.h"
#include "core/exported/WebFileChooserCompletionImpl.h"
+#include "core/exported/WebPluginContainerBase.h"
#include "core/exported/WebViewBase.h"
#include "core/frame/FrameView.h"
#include "core/frame/Settings.h"
@@ -122,7 +123,6 @@
#include "web/PopupMenuImpl.h"
#include "web/WebFrameWidgetImpl.h"
#include "web/WebLocalFrameImpl.h"
-#include "web/WebPluginContainerImpl.h"
#include "web/WebRemoteFrameImpl.h"
#include "web/WebSettingsImpl.h"
@@ -658,8 +658,8 @@ void ChromeClientImpl::ShowMouseOverURL(const HitTestResult& result) {
if (object && object->IsLayoutPart()) {
PluginView* plugin_view = ToLayoutPart(object)->Plugin();
if (plugin_view && plugin_view->IsPluginContainer()) {
- WebPluginContainerImpl* plugin =
- ToWebPluginContainerImpl(plugin_view);
+ WebPluginContainerBase* plugin =
+ ToWebPluginContainerBase(plugin_view);
url = plugin->Plugin()->LinkAtPosition(
result.RoundedPointInInnerNodeFrame());
}

Powered by Google App Engine
This is Rietveld 408576698