Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8160)

Unified Diff: chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc

Issue 2886083002: MD Settings: Use FireWebUIListener() helper wherever possible. (Closed)
Patch Set: resolve conflicts Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
index a0fb7dcaeb14d5420d1e1dbeec1680dde4e693f7..7f989b82761228abcf3db8660aa668d095799b84 100644
--- a/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
@@ -108,8 +108,7 @@ void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,
args.SetString(kId, model_util_->GetTreeNodeId(parent_node));
args.SetInteger(kStart, start);
args.Set(kChildren, std::move(children));
- CallJavascriptFunction("cr.webUIListenerCallback",
- base::Value("onTreeItemAdded"), args);
+ FireWebUIListener("on.TreeItemAdded", args);
dpapad 2017/05/19 19:39:43 Whoops. Something wrong with my regex capturing. I
dpapad 2017/05/19 20:35:35 Fixed. This was the only occurrence I found.
}
void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
@@ -129,8 +128,7 @@ void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
args.SetString(kId, model_util_->GetTreeNodeId(tree_model->AsNode(parent)));
args.SetInteger(kStart, start);
args.SetInteger(kCount, count);
- CallJavascriptFunction("cr.webUIListenerCallback",
- base::Value("onTreeItemRemoved"), args);
+ FireWebUIListener("onTreeItemRemoved", args);
}
void CookiesViewHandler::TreeModelBeginBatch(CookiesTreeModel* model) {

Powered by Google App Engine
This is Rietveld 408576698