Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: components/safe_browsing/base_ui_manager.cc

Issue 2886043002: Refrain from sending hit report when user is in incognito mode (Closed)
Patch Set: fixed comment typo Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/base_ui_manager.cc
diff --git a/components/safe_browsing/base_ui_manager.cc b/components/safe_browsing/base_ui_manager.cc
index cd8940d9e1c7ecd423f80e290a6704881c332224..97b1efa9a2c6b432984baf091f3ff5d55ea86b7d 100644
--- a/components/safe_browsing/base_ui_manager.cc
+++ b/components/safe_browsing/base_ui_manager.cc
@@ -245,10 +245,11 @@ void BaseUIManager::ShowBlockingPageForResource(
}
// A safebrowsing hit is sent after a blocking page for malware/phishing
vakh (use Gerrit instead) 2017/05/19 22:41:13 nit: SafeBrowsing
mortonm 2017/05/22 17:03:59 Done.
-// or after the warning dialog for download urls, only for
-// UMA || extended_reporting users.
+// or after the warning dialog for download urls, only for extended_reporting
+// users who are not in incognito mode.
void BaseUIManager::MaybeReportSafeBrowsingHit(
- const HitReport& hit_report) {
+ const HitReport& hit_report,
+ content::WebContents* web_contents) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
return;
}
« components/safe_browsing/base_ui_manager.h ('K') | « components/safe_browsing/base_ui_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698